Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(615)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/offline_pages/OWNERS
Issue
2881223002
:
Create chrome/browser/offline_pages to host browser-related parts of offline_pages whcih (Closed)
Patch Set: more BUILD.gn
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/BUILD.gn
chrome/browser/android/offline_pages/background_loader_offliner.h
chrome/browser/android/offline_pages/background_loader_offliner.cc
chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
chrome/browser/android/offline_pages/request_coordinator_factory.cc
chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
chrome/browser/offline_pages/OWNERS
chrome/browser/offline_pages/background_loader_offliner.h
chrome/browser/offline_pages/background_loader_offliner.cc
chrome/browser/offline_pages/background_loader_offliner_unittest.cc
chrome/test/BUILD.gn
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
('k') |
chrome/browser/offline_pages/background_loader_offliner.h »
('j') |
chrome/test/BUILD.gn »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
dewittj@chromium.org
dewittj
2017/05/16 00:06:37
can you just write: file://components/offline_pag
can you just write: file://components/offline_pages/OWNERS to reduce redundancy?
2
dimich@chromium.org
3
fgorski@chromium.org
4
jianli@chromium.org
5
petewil@chromium.org
6
7
# TEAM: offline-dev@chromium.org
8
# COMPONENT: UI>Browser>Offline
OLD
NEW
« no previous file with comments
|
« chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
('k') |
chrome/browser/offline_pages/background_loader_offliner.h »
('j') |
chrome/test/BUILD.gn »
('J')
Issue 2881223002: Create chrome/browser/offline_pages to host browser-related parts of offline_pages whcih (Closed)
Created 3 years, 7 months ago by Dmitry Titov
Modified 3 years, 7 months ago
Reviewers: dewittj, sky
Base URL:
Comments: 3
This is Rietveld
408576698