Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2881053003: DevTools: enable object previews experiment by default (Closed)

Created:
3 years, 7 months ago by luoe
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: enable object previews experiment by default BUG=607681 Review-Url: https://codereview.chromium.org/2881053003 Cr-Commit-Position: refs/heads/master@{#472014} Committed: https://chromium.googlesource.com/chromium/src/+/8cd4a51cd17b2b672793c6308e3ce4aa0f86adb5

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix extension sidebar test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -294 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-Object-overwritten-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-es6-expected.txt View 1 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-edit-property-value-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-global-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-object-literal-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-scoped-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-throw-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-undefined-override-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2-expected.txt View 1 1 chunk +68 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt View 1 4 chunks +80 lines, -80 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 1 23 chunks +49 lines, -49 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-functions-expected.txt View 1 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-toString-object-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt View 1 3 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-tainted-globals-expected.txt View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/exception-objects-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/worker-eval-contains-stack-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html View 1 2 4 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-expand-scope-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-inline-values-expected.txt View 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/properties-special-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
luoe
Please take a look. Just one line change, everything else is tests.
3 years, 7 months ago (2017-05-15 18:55:52 UTC) #2
pfeldman
On 2017/05/15 18:55:52, luoe wrote: > Please take a look. Just one line change, everything ...
3 years, 7 months ago (2017-05-15 19:00:22 UTC) #3
luoe
On 2017/05/15 19:00:22, pfeldman wrote: > On 2017/05/15 18:55:52, luoe wrote: > > Please take ...
3 years, 7 months ago (2017-05-15 22:02:04 UTC) #4
pfeldman
lgtm
3 years, 7 months ago (2017-05-15 22:28:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881053003/20001
3 years, 7 months ago (2017-05-15 22:30:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881053003/40001
3 years, 7 months ago (2017-05-15 23:45:33 UTC) #10
luoe
Fixed extension test by replacing `window.location` with a constructed named object with property.
3 years, 7 months ago (2017-05-15 23:45:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/426785)
3 years, 7 months ago (2017-05-16 01:55:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881053003/40001
3 years, 7 months ago (2017-05-16 02:04:14 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 04:12:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8cd4a51cd17b2b672793c6308e3c...

Powered by Google App Engine
This is Rietveld 408576698