Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2866363003: DevTools: format keys in object previews using sans serif. (Closed)

Created:
3 years, 7 months ago by pfeldman
Modified:
3 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: format keys in object previews using sans serif. NOTRY=try Review-Url: https://codereview.chromium.org/2866363003 Cr-Original-Commit-Position: refs/heads/master@{#471578} Committed: https://chromium.googlesource.com/chromium/src/+/14981e159fc950c0a628869e85c166c6c09809ca Review-Url: https://codereview.chromium.org/2866363003 Cr-Commit-Position: refs/heads/master@{#471894} Committed: https://chromium.googlesource.com/chromium/src/+/e632dfc199ac43378a3493f10853bfa44c8732dd

Patch Set 1 #

Patch Set 2 : same #

Patch Set 3 : w/ tests #

Total comments: 1

Patch Set 4 : removed the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -711 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-call-getter-on-proto-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/inspector/console/console-copy-truncated-text.html View 1 2 3 1 chunk +0 lines, -219 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-copy-truncated-text-expected.txt View 1 2 3 1 chunk +0 lines, -231 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-es6-expected.txt View 1 2 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-undefined-override-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-collections-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 1 2 12 chunks +92 lines, -92 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-functions-expected.txt View 1 2 5 chunks +46 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-short-hand-method-expected.txt View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-toString-object-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-native-function-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt View 1 2 1 chunk +36 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-tainted-globals-expected.txt View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/properties-special-expected.txt View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js View 1 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js View 1 3 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/objectPropertiesSection.css View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 25 (16 generated)
pfeldman
3 years, 7 months ago (2017-05-13 01:15:24 UTC) #2
dgozman
Please add a bug. lgtm https://codereview.chromium.org/2866363003/diff/40001/third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css File third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css (right): https://codereview.chromium.org/2866363003/diff/40001/third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css#newcode27 third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css:27: .object-value-boolean { This makes ...
3 years, 7 months ago (2017-05-13 01:43:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866363003/40001
3 years, 7 months ago (2017-05-13 06:29:48 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/14981e159fc950c0a628869e85c166c6c09809ca
3 years, 7 months ago (2017-05-13 07:52:13 UTC) #13
Justin Donnelly
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2878243002/ by jdonnelly@chromium.org. ...
3 years, 7 months ago (2017-05-13 16:15:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866363003/60001
3 years, 7 months ago (2017-05-15 18:17:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/228710)
3 years, 7 months ago (2017-05-15 19:06:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866363003/60001
3 years, 7 months ago (2017-05-15 20:15:00 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 20:55:43 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e632dfc199ac43378a3493f10853...

Powered by Google App Engine
This is Rietveld 408576698