Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html

Issue 2881053003: DevTools: enable object previews experiment by default (Closed)
Patch Set: fix extension sidebar test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
diff --git a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
index 195a58a6cddc71dc8b7a8800de56a29cca0f2ef2..2a708038b154988bc704677f6755f8f2c5cfbb44 100644
--- a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
+++ b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
@@ -136,6 +136,9 @@ function extension_testElementsSidebarSetExpression(nextTest)
function expression()
{
document.body.testProperty = 'foo';
+ function Foo() {};
+ var fooInstance = new Foo();
+ fooInstance.bar = 1;
return {
f0: 'expression',
f1: undefined,
@@ -145,7 +148,7 @@ function extension_testElementsSidebarSetExpression(nextTest)
f5: ["aa", "bb", "cc"],
f6: { f60: 42, f61: "foo", f62: [] },
f7: 42,
- f8: window.location,
+ f8: fooInstance,
f9: document.body.children,
f10: function() {},
f11: $0.testProperty
@@ -169,6 +172,9 @@ function extension_testSourcesSidebarSetExpression(nextTest)
function onSidebarExpanded(sidebar) {
function expression()
{
+ function Foo() {};
+ var fooInstance = new Foo();
+ fooInstance.bar = 1;
return {
f0: 'expression',
f1: undefined,
@@ -178,7 +184,7 @@ function extension_testSourcesSidebarSetExpression(nextTest)
f5: ["aa", "bb", "cc"],
f6: { f60: 42, f61: "foo", f62: [] },
f7: 42,
- f8: window.location,
+ f8: fooInstance,
f9: document.body.children,
f10: function() {},
};

Powered by Google App Engine
This is Rietveld 408576698