Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2881023002: Update the deprecation message of /deep/ and remove that of ::shadow (Closed)

Created:
3 years, 7 months ago by hayato
Modified:
3 years, 7 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the deprecation message of /deep/ and remove that of ::shadow This is one of clean up CLs after https://codereview.chromium.org/2778983006. BUG=489954 Review-Url: https://codereview.chromium.org/2881023002 Cr-Commit-Position: refs/heads/master@{#471711} Committed: https://chromium.googlesource.com/chromium/src/+/2c6439ccb2ec5de9b6986e31f22a49861ee2fa6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/apply-deep-in-document-scope-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
hayato
PTAL
3 years, 7 months ago (2017-05-15 08:09:16 UTC) #4
tkent
lgtm
3 years, 7 months ago (2017-05-15 08:14:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881023002/1
3 years, 7 months ago (2017-05-15 08:48:53 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 09:41:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c6439ccb2ec5de9b6986e31f22a...

Powered by Google App Engine
This is Rietveld 408576698