Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/64898) mac_chromium_rel_ng on ...
3 years, 8 months ago
(2017-03-29 07:34:38 UTC)
#4
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/411097)
3 years, 8 months ago
(2017-04-24 06:35:36 UTC)
#9
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/411200)
3 years, 8 months ago
(2017-04-24 12:30:04 UTC)
#14
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/437868)
3 years, 8 months ago
(2017-04-25 08:12:49 UTC)
#19
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/440040)
3 years, 8 months ago
(2017-04-27 07:52:44 UTC)
#24
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/414786)
3 years, 7 months ago
(2017-04-28 06:01:56 UTC)
#29
Description was changed from ========== (Don't land until M60) Make /deep/ as no-op and remove ...
3 years, 7 months ago
(2017-05-08 06:14:40 UTC)
#35
Description was changed from
==========
(Don't land until M60) Make /deep/ as no-op and remove ::shadow in dynamic
profile
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
To make this CL smaller, and easy to be reverted, all tests which depend on
/deep/
(or ::shadow) were either removed or updated in another CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
This CL only fixed the Web API surface so that users can't use /deep/ or
::shadow
in CSS dynamic profile. The further clean up is needed in other CLs.
BUG=489954
==========
to
==========
(Don't land until M60) Make /deep/ as no-op and remove ::shadow in dynamic
profile
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
To make this CL small one, and easy to be reverted, all tests which depend on
/deep/
(or ::shadow) were either removed or updated in another CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
This CL only fixed the Web API surface so that users can't use /deep/ or
::shadow
in CSS dynamic profile. The further clean up is needed in other CLs.
BUG=489954
==========
hayato
Description was changed from ========== (Don't land until M60) Make /deep/ as no-op and remove ...
3 years, 7 months ago
(2017-05-08 06:14:59 UTC)
#36
Description was changed from
==========
(Don't land until M60) Make /deep/ as no-op and remove ::shadow in dynamic
profile
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
To make this CL small one, and easy to be reverted, all tests which depend on
/deep/
(or ::shadow) were either removed or updated in another CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
This CL only fixed the Web API surface so that users can't use /deep/ or
::shadow
in CSS dynamic profile. The further clean up is needed in other CLs.
BUG=489954
==========
to
==========
(Don't land until M60) Make /deep/ as no-op and remove ::shadow in dynamic
profile
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
To make this CL small one, and easy to be reverted, all tests which depend on
/deep/
(or ::shadow) were either removed or updated in another CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
This CL only fixed the Web API surface so that users can't use /deep/ or
::shadow
in CSS dynamic profile. The further internal clean up is needed in other CLs.
BUG=489954
==========
hayato
Description was changed from ========== (Don't land until M60) Make /deep/ as no-op and remove ...
3 years, 7 months ago
(2017-05-08 06:21:45 UTC)
#37
Description was changed from
==========
(Don't land until M60) Make /deep/ as no-op and remove ::shadow in dynamic
profile
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
To make this CL small one, and easy to be reverted, all tests which depend on
/deep/
(or ::shadow) were either removed or updated in another CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
This CL only fixed the Web API surface so that users can't use /deep/ or
::shadow
in CSS dynamic profile. The further internal clean up is needed in other CLs.
BUG=489954
==========
to
==========
(Don't land until M60) Make /deep/ as no-op and remove ::shadow in dynamic
profile
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
To make this CL small one, and easy to be reverted, all tests which depend on
/deep/
(or ::shadow) were either removed or updated in another CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
This CL only touched the small part so that users can't use /deep/ or ::shadow
in CSS dynamic profile in M60. The further internal clean up is needed in other
CLs.
BUG=489954
==========
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago
(2017-05-08 08:26:26 UTC)
#38
PTAL I think the CL is ready to be reviewed. +achuith, alemate Regarding bug 719331, ...
3 years, 7 months ago
(2017-05-09 07:08:33 UTC)
#41
PTAL
I think the CL is ready to be reviewed.
+achuith, alemate
Regarding bug 719331, I am going to land this CL.
Could you confirm whether this regress ChromeOS Login UI or not?
kochi
https://codereview.chromium.org/2778983006/diff/120001/third_party/WebKit/Source/core/css/CSSSelector.h File third_party/WebKit/Source/core/css/CSSSelector.h (right): https://codereview.chromium.org/2778983006/diff/120001/third_party/WebKit/Source/core/css/CSSSelector.h#newcode137 third_party/WebKit/Source/core/css/CSSSelector.h:137: kShadowDeepAsDescendant, // /deep/ as an alias for descendant nit: ...
3 years, 7 months ago
(2017-05-09 14:29:38 UTC)
#42
Thanks you for the review. https://codereview.chromium.org/2778983006/diff/120001/third_party/WebKit/Source/core/css/CSSSelector.h File third_party/WebKit/Source/core/css/CSSSelector.h (right): https://codereview.chromium.org/2778983006/diff/120001/third_party/WebKit/Source/core/css/CSSSelector.h#newcode137 third_party/WebKit/Source/core/css/CSSSelector.h:137: kShadowDeepAsDescendant, // /deep/ as ...
3 years, 7 months ago
(2017-05-10 06:57:04 UTC)
#46
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449670)
3 years, 7 months ago
(2017-05-10 09:54:12 UTC)
#48
3 years, 7 months ago
(2017-05-11 06:42:33 UTC)
#53
Dry run: This issue passed the CQ dry run.
hayato
Description was changed from ========== (Don't land until M60) Make /deep/ as no-op and remove ...
3 years, 7 months ago
(2017-05-12 02:24:50 UTC)
#54
Description was changed from
==========
(Don't land until M60) Make /deep/ as no-op and remove ::shadow in dynamic
profile
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
To make this CL small one, and easy to be reverted, all tests which depend on
/deep/
(or ::shadow) were either removed or updated in another CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
This CL only touched the small part so that users can't use /deep/ or ::shadow
in CSS dynamic profile in M60. The further internal clean up is needed in other
CLs.
BUG=489954
==========
to
==========
Make /deep/ as no-op and remove ::shadow in dynamic profile
Intent to Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HX5Y8Ykr5Ns
To make this CL small one, and easy to be reverted, all tests which depend on
/deep/
(or ::shadow) were either removed or updated in another CL:
https://bugs.chromium.org/p/chromium/issues/detail?id=715034.
This CL only touched the small part so that users can't use /deep/ or ::shadow
in CSS dynamic profile in M60. The further internal clean up is needed in other
CLs.
BUG=489954
==========
hayato
rebased
3 years, 7 months ago
(2017-05-15 03:54:22 UTC)
#55
rebased
hayato
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
3 years, 7 months ago
(2017-05-15 03:54:24 UTC)
#56
Issue 2778983006: Make /deep/ as no-op and remove ::shadow in dynamic profile
(Closed)
Created 3 years, 8 months ago by hayato
Modified 3 years, 7 months ago
Reviewers: achuithb, Alexander Alekseev, kochi
Base URL:
Comments: 7