Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2881023002: Update the deprecation message of /deep/ and remove that of ::shadow (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 6ad05bf03c5caa89fc34fffe5790fa6aebd040f5..270163347edb1ebdcff5f8027b86f5eb56708d52 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -349,14 +349,11 @@ String Deprecation::DeprecationMessage(UseCounter::Feature feature) {
"details.";
case UseCounter::kCSSDeepCombinator:
- return String::Format(
- "/deep/ combinator is deprecated and will be a no-op in %s. See "
- "https://www.chromestatus.com/features/4964279606312960 for more "
- "details.",
- milestoneString(M60));
-
- case UseCounter::kCSSSelectorPseudoShadow:
- return willBeRemoved("::shadow pseudo-element", M60, "6750456638341120");
+ return "/deep/ combinator is no longer supported in CSS dynamic profile. "
+ "It is now effectively no-op, acting as if it were a descendant "
+ "combinator. You should consider to remove it. See "
+ "https://www.chromestatus.com/features/4964279606312960 for more "
+ "details.";
case UseCounter::kVREyeParametersOffset:
return replacedBy("VREyeParameters.offset",
« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698