Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2880963002: Move CursorList to its own file. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CursorList to its own file. When we generate external types like Length in ComputedStyle, we specify the path to the type (e.g. "platform/Length"). We then deduce the name of the type from the path ("Length"). This means that the type must be stored in a file with the same name. This patch moves CursorList to its own file so that it can be generated. BUG=628043 Review-Url: https://codereview.chromium.org/2880963002 Cr-Original-Commit-Position: refs/heads/master@{#471654} Committed: https://chromium.googlesource.com/chromium/src/+/79e3cc6d695903af9f32b770fd80f67e878587e7 Review-Url: https://codereview.chromium.org/2880963002 Cr-Commit-Position: refs/heads/master@{#471682} Committed: https://chromium.googlesource.com/chromium/src/+/9f9fcf0ea74f3184b59b09dc5a3ef9f684e3af64

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M third_party/WebKit/Source/core/style/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/style/CursorList.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 27 (19 generated)
shend
Hi Suzy, PTAL :)
3 years, 7 months ago (2017-05-15 00:23:46 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm with nit https://codereview.chromium.org/2880963002/diff/1/third_party/WebKit/Source/core/style/CursorList.h File third_party/WebKit/Source/core/style/CursorList.h (right): https://codereview.chromium.org/2880963002/diff/1/third_party/WebKit/Source/core/style/CursorList.h#newcode19 third_party/WebKit/Source/core/style/CursorList.h:19: #endif Extra endif
3 years, 7 months ago (2017-05-15 00:30:01 UTC) #5
shend
https://codereview.chromium.org/2880963002/diff/1/third_party/WebKit/Source/core/style/CursorList.h File third_party/WebKit/Source/core/style/CursorList.h (right): https://codereview.chromium.org/2880963002/diff/1/third_party/WebKit/Source/core/style/CursorList.h#newcode19 third_party/WebKit/Source/core/style/CursorList.h:19: #endif On 2017/05/15 at 00:30:01, suzyh_UTC10 wrote: > Extra ...
3 years, 7 months ago (2017-05-15 00:36:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880963002/20001
3 years, 7 months ago (2017-05-15 03:17:43 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/79e3cc6d695903af9f32b770fd80f67e878587e7
3 years, 7 months ago (2017-05-15 03:21:44 UTC) #16
nainar
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2878353002/ by nainar@chromium.org. ...
3 years, 7 months ago (2017-05-15 03:41:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880963002/40001
3 years, 7 months ago (2017-05-15 06:22:11 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 06:26:38 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f9fcf0ea74f3184b59b09dc5a3e...

Powered by Google App Engine
This is Rietveld 408576698