Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issue 2884553002: Move AppliedTextDecorationList to its own file. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AppliedTextDecorationList to its own file. When we generate external types like Length in ComputedStyle, we specify the path to the type (e.g. "platform/Length"). We then deduce the name of the type from the path ("Length"). This means that the type must be stored in a file with the same name. This patch moves AppliedTextDecorationList to its own file so that it can be generated. BUG=628043 Review-Url: https://codereview.chromium.org/2884553002 Cr-Original-Commit-Position: refs/heads/master@{#471653} Committed: https://chromium.googlesource.com/chromium/src/+/762e2d87addf15f32ac5bda17b1ad9a8fb25dee2 Review-Url: https://codereview.chromium.org/2884553002 Cr-Commit-Position: refs/heads/master@{#471677} Committed: https://chromium.googlesource.com/chromium/src/+/1d5c7897e427cf28b15c6c4aa995f2fe7d16162c

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
A third_party/WebKit/Source/core/style/AppliedTextDecorationList.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 2 chunks +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (18 generated)
shend
Hi Suzy, PTAL :)
3 years, 7 months ago (2017-05-15 00:23:56 UTC) #6
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 7 months ago (2017-05-15 00:31:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884553002/20001
3 years, 7 months ago (2017-05-15 02:59:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/762e2d87addf15f32ac5bda17b1ad9a8fb25dee2
3 years, 7 months ago (2017-05-15 03:04:42 UTC) #14
nainar
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2880963003/ by nainar@chromium.org. ...
3 years, 7 months ago (2017-05-15 03:41:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884553002/40001
3 years, 7 months ago (2017-05-15 05:44:27 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 05:48:36 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1d5c7897e427cf28b15c6c4aa995...

Powered by Google App Engine
This is Rietveld 408576698