Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2883813002:
Move TextJustify to its own file. (Closed)
DescriptionMove TextJustify to its own file.
When we generate external types like Length in ComputedStyle, we specify
the path to the type (e.g. "platform/Length"). We then deduce the name
of the type from the path ("Length"). This means that the type must be
stored in a file with the same name.
This patch moves TextJustify to its own file so that it
can be generated.
BUG=628043
Review-Url: https://codereview.chromium.org/2883813002
Cr-Commit-Position: refs/heads/master@{#471948}
Committed: https://chromium.googlesource.com/chromium/src/+/dc8b3ef5667dfec73a697d1115e19832ea6341bb
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add build #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 29 (20 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shend@chromium.org changed reviewers: + suzyh@chromium.org
Hi Suzy, PTAL :)
lgtm with curiosity https://codereview.chromium.org/2883813002/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/text/TextJustify.h (right): https://codereview.chromium.org/2883813002/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/text/TextJustify.h:11: kTextJustifyAuto = 0x0, Why do we give values for these?
On 2017/05/15 at 00:28:33, suzyh wrote: > lgtm with curiosity > > https://codereview.chromium.org/2883813002/diff/1/third_party/WebKit/Source/p... > File third_party/WebKit/Source/platform/text/TextJustify.h (right): > > https://codereview.chromium.org/2883813002/diff/1/third_party/WebKit/Source/p... > third_party/WebKit/Source/platform/text/TextJustify.h:11: kTextJustifyAuto = 0x0, > Why do we give values for these? Good question :P I have no idea, maybe to be explicit that the order matters? Also interestingly, None is 1 and Auto is 0. Would've thought None is usually 0 :thinking:
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by shend@chromium.org
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org Link to the patchset: https://codereview.chromium.org/2883813002/#ps20001 (title: "Add build")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
shend@chromium.org changed reviewers: + haraken@chromium.org
Hi Haraken, PTAL for platform/
LGTM
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494891182863060,
"parent_rev": "91c16bd5245bc0e199b33ba634ef0896ab396c01", "commit_rev":
"be31e69226d6c726e21fbd0c939678dbb26dcb94"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494891182863060,
"parent_rev": "35d4f7020e94ad8e800544fb9fc01721dc942912", "commit_rev":
"dc8b3ef5667dfec73a697d1115e19832ea6341bb"}
Message was sent while issue was closed.
Description was changed from
==========
Move TextJustify to its own file.
When we generate external types like Length in ComputedStyle, we specify
the path to the type (e.g. "platform/Length"). We then deduce the name
of the type from the path ("Length"). This means that the type must be
stored in a file with the same name.
This patch moves TextJustify to its own file so that it
can be generated.
BUG=628043
==========
to
==========
Move TextJustify to its own file.
When we generate external types like Length in ComputedStyle, we specify
the path to the type (e.g. "platform/Length"). We then deduce the name
of the type from the path ("Length"). This means that the type must be
stored in a file with the same name.
This patch moves TextJustify to its own file so that it
can be generated.
BUG=628043
Review-Url: https://codereview.chromium.org/2883813002
Cr-Commit-Position: refs/heads/master@{#471948}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc8b3ef5667dfec73a697d1115e1...
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/dc8b3ef5667dfec73a697d1115e1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
