DescriptionRevert of Add stable id to PaintImage. (patchset #3 id:40001 of https://codereview.chromium.org/2873003002/ )
Reason for revert:
This change introduced a static initializer: PaintImage::s_next_id_.
See resulting failure at: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/39538.
Original issue's description:
> Add stable id to PaintImage.
>
> This patch adds a stable id into PaintImage. This is stable in the sense
> that if the blink::Image that generated the paint image hasn't changed,
> then the id would be the same. It's used in a case where either we have
> a partially loaded image that finishes loading or an animated image
> ticks to a new frame. In those cases, the SkImage unique id is different
> since the contents of the image are different. However, the stable id
> should remain the same to indicate that it's a part of logically the
> same image.
>
> The primary use for the stable id would be to determine whether the
> compositor is allowed to checker the image. Specifically, if we have
> ever displayed an image stable id X, then all other images with the
> same stable id X are not allowed to be checker imaged.
>
> R=khushalsagar@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2873003002
> Cr-Commit-Position: refs/heads/master@{#471351}
> Committed: https://chromium.googlesource.com/chromium/src/+/ae192fde12e7fba4ac2d8f027037d10c3d0f22a4
TBR=chrishtr@chromium.org,chcunningham@chromium.org,khushalsagar@chromium.org,piman@chromium.org,vmpstr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2880813002
Cr-Commit-Position: refs/heads/master@{#471386}
Committed: https://chromium.googlesource.com/chromium/src/+/5498d306eda382fcf8abe4c2cfaa2d7ca1f1580d
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|