Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2880813002: Revert of Add stable id to PaintImage. (Closed)

Created:
3 years, 7 months ago by Justin Donnelly
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dshwang, drott+blinkwatch_chromium.org, krit, feature-media-reviews_chromium.org, fmalita+watch_chromium.org, jam, Justin Novosad, kinuko+watch, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, posciak+watch_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add stable id to PaintImage. (patchset #3 id:40001 of https://codereview.chromium.org/2873003002/ ) Reason for revert: This change introduced a static initializer: PaintImage::s_next_id_. See resulting failure at: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/39538. Original issue's description: > Add stable id to PaintImage. > > This patch adds a stable id into PaintImage. This is stable in the sense > that if the blink::Image that generated the paint image hasn't changed, > then the id would be the same. It's used in a case where either we have > a partially loaded image that finishes loading or an animated image > ticks to a new frame. In those cases, the SkImage unique id is different > since the contents of the image are different. However, the stable id > should remain the same to indicate that it's a part of logically the > same image. > > The primary use for the stable id would be to determine whether the > compositor is allowed to checker the image. Specifically, if we have > ever displayed an image stable id X, then all other images with the > same stable id X are not allowed to be checker imaged. > > R=khushalsagar@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2873003002 > Cr-Commit-Position: refs/heads/master@{#471351} > Committed: https://chromium.googlesource.com/chromium/src/+/ae192fde12e7fba4ac2d8f027037d10c3d0f22a4 TBR=chrishtr@chromium.org,chcunningham@chromium.org,khushalsagar@chromium.org,piman@chromium.org,vmpstr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2880813002 Cr-Commit-Position: refs/heads/master@{#471386} Committed: https://chromium.googlesource.com/chromium/src/+/5498d306eda382fcf8abe4c2cfaa2d7ca1f1580d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -100 lines) Patch
M cc/layers/picture_image_layer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/paint/discardable_image_map_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M cc/paint/discardable_image_store.h View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/paint/discardable_image_store.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/paint/paint_image.h View 3 chunks +1 line, -16 lines 0 comments Download
M cc/paint/paint_image.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M cc/paint/paint_op_buffer_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M cc/paint/record_paint_canvas.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M cc/test/fake_content_layer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_blending.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/child_frame_compositing_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/DragImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp View 5 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Justin Donnelly
Created Revert of Add stable id to PaintImage.
3 years, 7 months ago (2017-05-12 18:44:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880813002/1
3 years, 7 months ago (2017-05-12 18:45:37 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 18:47:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5498d306eda382fcf8abe4c2cfaa...

Powered by Google App Engine
This is Rietveld 408576698