Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

Issue 2880813002: Revert of Add stable id to PaintImage. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 156
157 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecord) { 157 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecord) {
158 lazy_decoder_->SetData(data_, true); 158 lazy_decoder_->SetData(data_, true);
159 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0); 159 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0);
160 ASSERT_TRUE(image); 160 ASSERT_TRUE(image);
161 EXPECT_EQ(1, image->width()); 161 EXPECT_EQ(1, image->width());
162 EXPECT_EQ(1, image->height()); 162 EXPECT_EQ(1, image->height());
163 163
164 PaintRecorder recorder; 164 PaintRecorder recorder;
165 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100); 165 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100);
166 temp_canvas->drawImage(PaintImage(PaintImage::GetNextId(), std::move(image)), 166 temp_canvas->drawImage(PaintImage(std::move(image)), 0, 0);
167 0, 0);
168 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture(); 167 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture();
169 EXPECT_EQ(0, decode_request_count_); 168 EXPECT_EQ(0, decode_request_count_);
170 169
171 canvas_->drawPicture(record); 170 canvas_->drawPicture(record);
172 EXPECT_EQ(0, decode_request_count_); 171 EXPECT_EQ(0, decode_request_count_);
173 EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0)); 172 EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0));
174 } 173 }
175 174
176 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecordProgressive) { 175 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecordProgressive) {
177 RefPtr<SharedBuffer> partial_data = 176 RefPtr<SharedBuffer> partial_data =
178 SharedBuffer::Create(data_->Data(), data_->size() - 10); 177 SharedBuffer::Create(data_->Data(), data_->size() - 10);
179 178
180 // Received only half the file. 179 // Received only half the file.
181 lazy_decoder_->SetData(partial_data, false); 180 lazy_decoder_->SetData(partial_data, false);
182 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0); 181 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0);
183 ASSERT_TRUE(image); 182 ASSERT_TRUE(image);
184 PaintRecorder recorder; 183 PaintRecorder recorder;
185 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100); 184 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100);
186 PaintImage::Id stable_id = PaintImage::GetNextId();
187 temp_canvas->drawImage( 185 temp_canvas->drawImage(
188 PaintImage(stable_id, std::move(image), PaintImage::AnimationType::STATIC, 186 PaintImage(std::move(image), PaintImage::AnimationType::STATIC,
189 PaintImage::CompletionState::PARTIALLY_DONE), 187 PaintImage::CompletionState::PARTIALLY_DONE),
190 0, 0); 188 0, 0);
191 canvas_->drawPicture(recorder.finishRecordingAsPicture()); 189 canvas_->drawPicture(recorder.finishRecordingAsPicture());
192 190
193 // Fully received the file and draw the PaintRecord again. 191 // Fully received the file and draw the PaintRecord again.
194 lazy_decoder_->SetData(data_, true); 192 lazy_decoder_->SetData(data_, true);
195 image = lazy_decoder_->CreateFrameAtIndex(0); 193 image = lazy_decoder_->CreateFrameAtIndex(0);
196 ASSERT_TRUE(image); 194 ASSERT_TRUE(image);
197 temp_canvas = recorder.beginRecording(100, 100); 195 temp_canvas = recorder.beginRecording(100, 100);
198 temp_canvas->drawImage(PaintImage(stable_id, std::move(image)), 0, 0); 196 temp_canvas->drawImage(PaintImage(std::move(image)), 0, 0);
199 canvas_->drawPicture(recorder.finishRecordingAsPicture()); 197 canvas_->drawPicture(recorder.finishRecordingAsPicture());
200 EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0)); 198 EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0));
201 } 199 }
202 200
203 static void RasterizeMain(PaintCanvas* canvas, sk_sp<PaintRecord> record) { 201 static void RasterizeMain(PaintCanvas* canvas, sk_sp<PaintRecord> record) {
204 canvas->drawPicture(record); 202 canvas->drawPicture(record);
205 } 203 }
206 204
207 TEST_F(DeferredImageDecoderTest, decodeOnOtherThread) { 205 TEST_F(DeferredImageDecoderTest, decodeOnOtherThread) {
208 lazy_decoder_->SetData(data_, true); 206 lazy_decoder_->SetData(data_, true);
209 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0); 207 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0);
210 ASSERT_TRUE(image); 208 ASSERT_TRUE(image);
211 EXPECT_EQ(1, image->width()); 209 EXPECT_EQ(1, image->width());
212 EXPECT_EQ(1, image->height()); 210 EXPECT_EQ(1, image->height());
213 211
214 PaintRecorder recorder; 212 PaintRecorder recorder;
215 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100); 213 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100);
216 temp_canvas->drawImage(PaintImage(PaintImage::GetNextId(), std::move(image)), 214 temp_canvas->drawImage(PaintImage(std::move(image)), 0, 0);
217 0, 0);
218 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture(); 215 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture();
219 EXPECT_EQ(0, decode_request_count_); 216 EXPECT_EQ(0, decode_request_count_);
220 217
221 // Create a thread to rasterize PaintRecord. 218 // Create a thread to rasterize PaintRecord.
222 std::unique_ptr<WebThread> thread = 219 std::unique_ptr<WebThread> thread =
223 Platform::Current()->CreateThread("RasterThread"); 220 Platform::Current()->CreateThread("RasterThread");
224 thread->GetWebTaskRunner()->PostTask( 221 thread->GetWebTaskRunner()->PostTask(
225 BLINK_FROM_HERE, 222 BLINK_FROM_HERE,
226 CrossThreadBind(&RasterizeMain, CrossThreadUnretained(canvas_.get()), 223 CrossThreadBind(&RasterizeMain, CrossThreadUnretained(canvas_.get()),
227 record)); 224 record));
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0); 298 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0);
302 ASSERT_TRUE(image); 299 ASSERT_TRUE(image);
303 EXPECT_EQ(decoded_size_.Width(), image->width()); 300 EXPECT_EQ(decoded_size_.Width(), image->width());
304 EXPECT_EQ(decoded_size_.Height(), image->height()); 301 EXPECT_EQ(decoded_size_.Height(), image->height());
305 302
306 UseMockImageDecoderFactory(); 303 UseMockImageDecoderFactory();
307 304
308 // The following code should not fail any assert. 305 // The following code should not fail any assert.
309 PaintRecorder recorder; 306 PaintRecorder recorder;
310 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100); 307 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100);
311 temp_canvas->drawImage(PaintImage(PaintImage::GetNextId(), std::move(image)), 308 temp_canvas->drawImage(PaintImage(std::move(image)), 0, 0);
312 0, 0);
313 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture(); 309 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture();
314 EXPECT_EQ(0, decode_request_count_); 310 EXPECT_EQ(0, decode_request_count_);
315 canvas_->drawPicture(record); 311 canvas_->drawPicture(record);
316 EXPECT_EQ(1, decode_request_count_); 312 EXPECT_EQ(1, decode_request_count_);
317 } 313 }
318 314
319 TEST_F(DeferredImageDecoderTest, smallerFrameCount) { 315 TEST_F(DeferredImageDecoderTest, smallerFrameCount) {
320 frame_count_ = 1; 316 frame_count_ = 1;
321 lazy_decoder_->SetData(data_, false); 317 lazy_decoder_->SetData(data_, false);
322 EXPECT_EQ(frame_count_, lazy_decoder_->FrameCount()); 318 EXPECT_EQ(frame_count_, lazy_decoder_->FrameCount());
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 SharedBuffer::Create(data_->Data(), data_->size()); 383 SharedBuffer::Create(data_->Data(), data_->size());
388 EXPECT_EQ(original_data->size(), data_->size()); 384 EXPECT_EQ(original_data->size(), data_->size());
389 lazy_decoder_->SetData(original_data, false); 385 lazy_decoder_->SetData(original_data, false);
390 RefPtr<SharedBuffer> new_data = lazy_decoder_->Data(); 386 RefPtr<SharedBuffer> new_data = lazy_decoder_->Data();
391 EXPECT_EQ(original_data->size(), new_data->size()); 387 EXPECT_EQ(original_data->size(), new_data->size());
392 EXPECT_EQ(0, std::memcmp(original_data->Data(), new_data->Data(), 388 EXPECT_EQ(0, std::memcmp(original_data->Data(), new_data->Data(),
393 new_data->size())); 389 new_data->size()));
394 } 390 }
395 391
396 } // namespace blink 392 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/DragImage.cpp ('k') | third_party/WebKit/Source/platform/graphics/Image.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698