Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2880483002: Minor cleanup of QuicChromiumClientStreamTest (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor cleanup of QuicChromiumClientStreamTest * Remove an unused MOCK_METHOD * Create a "real" stream instead of a "test" stream. BUG=716563 Review-Url: https://codereview.chromium.org/2880483002 Cr-Commit-Position: refs/heads/master@{#470755} Committed: https://chromium.googlesource.com/chromium/src/+/43535f1beb4135a9f860fdae5b99ec0a5e4e9374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M net/quic/chromium/quic_chromium_client_stream_test.cc View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Ryan Hamilton
3 years, 7 months ago (2017-05-10 22:31:30 UTC) #2
Zhongyi Shi
lgtm
3 years, 7 months ago (2017-05-10 22:37:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880483002/1
3 years, 7 months ago (2017-05-10 22:41:29 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 23:50:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43535f1beb4135a9f860fdae5b99...

Powered by Google App Engine
This is Rietveld 408576698