Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: net/quic/chromium/quic_chromium_client_stream_test.cc

Issue 2880483002: Minor cleanup of QuicChromiumClientStreamTest (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_stream_test.cc
diff --git a/net/quic/chromium/quic_chromium_client_stream_test.cc b/net/quic/chromium/quic_chromium_client_stream_test.cc
index 0a3888a3a59bfd8d6dc8acdea222e1a18babaf95..735c1013457620c3265184c5782eee2e1c709ce4 100644
--- a/net/quic/chromium/quic_chromium_client_stream_test.cc
+++ b/net/quic/chromium/quic_chromium_client_stream_test.cc
@@ -58,7 +58,6 @@ class MockDelegate : public QuicChromiumClientStream::Delegate {
}
MOCK_METHOD2(OnTrailingHeadersAvailableMock,
void(const SpdyHeaderBlock& headers, size_t frame_len));
- MOCK_METHOD2(OnDataReceived, int(const char*, int));
MOCK_METHOD0(OnDataAvailable, void());
MOCK_METHOD0(OnClose, void());
MOCK_METHOD1(OnError, void(int));
@@ -71,14 +70,6 @@ class MockDelegate : public QuicChromiumClientStream::Delegate {
DISALLOW_COPY_AND_ASSIGN(MockDelegate);
};
-class TestQuicClientSessionBaseStream : public QuicSpdyStream {
- public:
- TestQuicClientSessionBaseStream(QuicStreamId id, QuicSpdySession* session)
- : QuicSpdyStream(id, session) {}
-
- void OnDataAvailable() override {}
-};
-
class MockQuicClientSessionBase : public QuicClientSessionBase {
public:
explicit MockQuicClientSessionBase(QuicConnection* connection,
@@ -149,7 +140,8 @@ class MockQuicClientSessionBase : public QuicClientSessionBase {
MOCK_METHOD1(OnHeadersHeadOfLineBlocking, void(QuicTime::Delta delta));
std::unique_ptr<QuicStream> CreateStream(QuicStreamId id) {
- return QuicMakeUnique<TestQuicClientSessionBaseStream>(id, this);
+ return QuicMakeUnique<QuicChromiumClientStream>(id, this,
+ NetLogWithSource());
}
using QuicSession::ActivateStream;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698