Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: net/quic/chromium/quic_chromium_client_stream_test.cc

Issue 2880483002: Minor cleanup of QuicChromiumClientStreamTest (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/chromium/quic_chromium_client_stream.h" 5 #include "net/quic/chromium/quic_chromium_client_stream.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 } 51 }
52 MOCK_METHOD2(OnInitialHeadersAvailableMock, 52 MOCK_METHOD2(OnInitialHeadersAvailableMock,
53 void(const SpdyHeaderBlock& headers, size_t frame_len)); 53 void(const SpdyHeaderBlock& headers, size_t frame_len));
54 void OnTrailingHeadersAvailable(const SpdyHeaderBlock& headers, 54 void OnTrailingHeadersAvailable(const SpdyHeaderBlock& headers,
55 size_t frame_len) override { 55 size_t frame_len) override {
56 trailers_ = headers.Clone(); 56 trailers_ = headers.Clone();
57 OnTrailingHeadersAvailableMock(headers, frame_len); 57 OnTrailingHeadersAvailableMock(headers, frame_len);
58 } 58 }
59 MOCK_METHOD2(OnTrailingHeadersAvailableMock, 59 MOCK_METHOD2(OnTrailingHeadersAvailableMock,
60 void(const SpdyHeaderBlock& headers, size_t frame_len)); 60 void(const SpdyHeaderBlock& headers, size_t frame_len));
61 MOCK_METHOD2(OnDataReceived, int(const char*, int));
62 MOCK_METHOD0(OnDataAvailable, void()); 61 MOCK_METHOD0(OnDataAvailable, void());
63 MOCK_METHOD0(OnClose, void()); 62 MOCK_METHOD0(OnClose, void());
64 MOCK_METHOD1(OnError, void(int)); 63 MOCK_METHOD1(OnError, void(int));
65 MOCK_METHOD0(HasSendHeadersComplete, bool()); 64 MOCK_METHOD0(HasSendHeadersComplete, bool());
66 65
67 SpdyHeaderBlock headers_; 66 SpdyHeaderBlock headers_;
68 SpdyHeaderBlock trailers_; 67 SpdyHeaderBlock trailers_;
69 68
70 private: 69 private:
71 DISALLOW_COPY_AND_ASSIGN(MockDelegate); 70 DISALLOW_COPY_AND_ASSIGN(MockDelegate);
72 }; 71 };
73 72
74 class TestQuicClientSessionBaseStream : public QuicSpdyStream {
75 public:
76 TestQuicClientSessionBaseStream(QuicStreamId id, QuicSpdySession* session)
77 : QuicSpdyStream(id, session) {}
78
79 void OnDataAvailable() override {}
80 };
81
82 class MockQuicClientSessionBase : public QuicClientSessionBase { 73 class MockQuicClientSessionBase : public QuicClientSessionBase {
83 public: 74 public:
84 explicit MockQuicClientSessionBase(QuicConnection* connection, 75 explicit MockQuicClientSessionBase(QuicConnection* connection,
85 QuicClientPushPromiseIndex* index); 76 QuicClientPushPromiseIndex* index);
86 ~MockQuicClientSessionBase() override; 77 ~MockQuicClientSessionBase() override;
87 78
88 const QuicCryptoStream* GetCryptoStream() const override { 79 const QuicCryptoStream* GetCryptoStream() const override {
89 return crypto_stream_.get(); 80 return crypto_stream_.get();
90 } 81 }
91 82
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 WriteHeadersMock, 133 WriteHeadersMock,
143 size_t(QuicStreamId id, 134 size_t(QuicStreamId id,
144 const SpdyHeaderBlock& headers, 135 const SpdyHeaderBlock& headers,
145 bool fin, 136 bool fin,
146 SpdyPriority priority, 137 SpdyPriority priority,
147 const QuicReferenceCountedPointer<QuicAckListenerInterface>& 138 const QuicReferenceCountedPointer<QuicAckListenerInterface>&
148 ack_listener)); 139 ack_listener));
149 MOCK_METHOD1(OnHeadersHeadOfLineBlocking, void(QuicTime::Delta delta)); 140 MOCK_METHOD1(OnHeadersHeadOfLineBlocking, void(QuicTime::Delta delta));
150 141
151 std::unique_ptr<QuicStream> CreateStream(QuicStreamId id) { 142 std::unique_ptr<QuicStream> CreateStream(QuicStreamId id) {
152 return QuicMakeUnique<TestQuicClientSessionBaseStream>(id, this); 143 return QuicMakeUnique<QuicChromiumClientStream>(id, this,
144 NetLogWithSource());
153 } 145 }
154 146
155 using QuicSession::ActivateStream; 147 using QuicSession::ActivateStream;
156 148
157 // Returns a QuicConsumedData that indicates all of |data| (and |fin| if set) 149 // Returns a QuicConsumedData that indicates all of |data| (and |fin| if set)
158 // has been consumed. 150 // has been consumed.
159 static QuicConsumedData ConsumeAllData( 151 static QuicConsumedData ConsumeAllData(
160 QuicStreamId id, 152 QuicStreamId id,
161 const QuicIOVector& data, 153 const QuicIOVector& data,
162 QuicStreamOffset offset, 154 QuicStreamOffset offset,
(...skipping 622 matching lines...) Expand 10 before | Expand all | Expand 10 after
785 EXPECT_EQ(QuicStringPiece(data), QuicStringPiece(buffer->data(), data_len)); 777 EXPECT_EQ(QuicStringPiece(data), QuicStringPiece(buffer->data(), data_len));
786 778
787 // Both delegates should be notified that theirs streams are closed. 779 // Both delegates should be notified that theirs streams are closed.
788 EXPECT_CALL(delegate2_, OnClose()); 780 EXPECT_CALL(delegate2_, OnClose());
789 EXPECT_CALL(delegate_, OnClose()); 781 EXPECT_CALL(delegate_, OnClose());
790 } 782 }
791 783
792 } // namespace 784 } // namespace
793 } // namespace test 785 } // namespace test
794 } // namespace net 786 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698