Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2880263002: Clear document scope dirtiness in import StyleEngine. (Closed)

Created:
3 years, 7 months ago by rune
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear document scope dirtiness in import StyleEngine. This is part of the plan to fix 717506 by re-collect sheets for style_sheets_for_style_sheet_list_ separately from updating all of active style to make it more light-weight. Some sanity checking and comment about document scope dirtiness in, and clear dirtiness after updating active sheets for, html imports. Also renamed to UpdateActiveStyleSheetsInImport() to make it clearer what the method does. BUG=717506 Review-Url: https://codereview.chromium.org/2880263002 Cr-Commit-Position: refs/heads/master@{#472447} Committed: https://chromium.googlesource.com/chromium/src/+/30a51b712800d2197a211b058dadb4a2c7762fed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (13 generated)
rune
ptal
3 years, 7 months ago (2017-05-15 14:22:01 UTC) #6
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-16 07:08:17 UTC) #7
rune
jochen@ for web/
3 years, 7 months ago (2017-05-16 08:18:03 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-16 11:16:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880263002/1
3 years, 7 months ago (2017-05-16 19:44:15 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/428293)
3 years, 7 months ago (2017-05-17 03:00:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880263002/1
3 years, 7 months ago (2017-05-17 07:09:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/428901)
3 years, 7 months ago (2017-05-17 09:21:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880263002/1
3 years, 7 months ago (2017-05-17 12:52:43 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 14:19:31 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30a51b712800d2197a211b058dad...

Powered by Google App Engine
This is Rietveld 408576698