Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2883003002: Allocate CSSGlobalRuleSet on heap. (Closed)

Created:
3 years, 7 months ago by rune
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allocate CSSGlobalRuleSet on heap. Avoids allocating the CSSGlobalRuleSet on html import StyleEngines. Review-Url: https://codereview.chromium.org/2883003002 Cr-Commit-Position: refs/heads/master@{#472186} Committed: https://chromium.googlesource.com/chromium/src/+/7fcceecb206ec84e00ce9d52b7e487fd92a27aee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -25 lines) Patch
M third_party/WebKit/Source/core/css/CSSGlobalRuleSet.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 5 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 12 chunks +37 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
rune
ptal
3 years, 7 months ago (2017-05-15 14:21:42 UTC) #6
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-16 07:07:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883003002/1
3 years, 7 months ago (2017-05-16 17:12:37 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 19:36:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fcceecb206ec84e00ce9d52b7e4...

Powered by Google App Engine
This is Rietveld 408576698