Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2880303002: Update styleSheets list in import without active style update. (Closed)

Created:
3 years, 7 months ago by rune
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update styleSheets list in import without active style update. Querying document.styleSheets should not need to do a full active style update. This CL is implementing a light-weight update of the styleSheets list querying document.styleSheets on html import documents. We collect and swap style_sheets_for_style_sheet_list_ for the collection of the import document without touching the active style or the dirty flags for active style on the master document. This is straightforward for import documents as they don't have an active stylesheet list themselves. Doing this optimization for top level documents and shadow trees is the next step, but we need to be more careful for those cases to keep the dirtyness without having to re- collect for the styleSheets api every time. BUG=717506 Review-Url: https://codereview.chromium.org/2880303002 Cr-Commit-Position: refs/heads/master@{#472751} Committed: https://chromium.googlesource.com/chromium/src/+/b5049772af9303fbb1dcdfe233900dfc80700ca1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +22 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp View 1 chunk +20 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (13 generated)
rune
ptal
3 years, 7 months ago (2017-05-15 14:22:20 UTC) #4
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-16 07:09:49 UTC) #7
rune
jochen@ for web/
3 years, 7 months ago (2017-05-16 08:20:03 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-16 11:16:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880303002/1
3 years, 7 months ago (2017-05-17 14:27:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457426)
3 years, 7 months ago (2017-05-17 15:58:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880303002/1
3 years, 7 months ago (2017-05-17 19:04:03 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457916)
3 years, 7 months ago (2017-05-17 21:24:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880303002/1
3 years, 7 months ago (2017-05-18 09:18:27 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 09:23:52 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5049772af9303fbb1dcdfe23390...

Powered by Google App Engine
This is Rietveld 408576698