DevTools: Show product badge in console

DevTools: Show product badge in console

BUG=721538
Review-Url: https://codereview.chromium.org/2879973003
Cr-Commit-Position: refs/heads/master@{#472030}
Committed: https://chromium.googlesource.com/chromium/src/+/6fce1c41322e02c9c1d70bbe1c420ef8269896de

[einbinder, 2017-05-15 18:56:17]

einbinder@chromium.org changed reviewers:
+ pfeldman@chromium.org

[einbinder, 2017-05-15 18:56:17]

Ptal

[pfeldman, 2017-05-15 20:41:31]

lgtm % nits

https://codereview.chromium.org/2879973003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2879973003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:938:
this._nameBadgeElement.classList.add('badge');
network-badge

https://codereview.chromium.org/2879973003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
(right):

https://codereview.chromium.org/2879973003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js:104:
badgeElement.style.backgroundColor =
ProductRegistry.BadgePool._colorForId(entryName);
BadgePool.colorForEntryName (I made it public)

[einbinder, 2017-05-15 21:00:08]

https://codereview.chromium.org/2879973003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2879973003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:938:
this._nameBadgeElement.classList.add('badge');
On 2017/05/15 at 20:41:31, pfeldman wrote:
> network-badge

Done.

https://codereview.chromium.org/2879973003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
(right):

https://codereview.chromium.org/2879973003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js:104:
badgeElement.style.backgroundColor =
ProductRegistry.BadgePool._colorForId(entryName);
On 2017/05/15 at 20:41:31, pfeldman wrote:
> BadgePool.colorForEntryName (I made it public)

Wasn't my code, so it is already fixed.

[einbinder, 2017-05-15 21:56:03]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 21:57:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 22:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 22:03:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[einbinder, 2017-05-15 22:53:51]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-05-15 22:55:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:01:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:01:37]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[einbinder, 2017-05-15 23:29:14]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-05-15 23:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2879973003/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2017-05-15 23:30:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:36:34]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[einbinder, 2017-05-15 23:58:39]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-05-15 23:58:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2879973003/#ps40001
(title: "Merge branch 'master' into badge_final")

[commit-bot: I haz the power, 2017-05-15 23:59:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:02:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:02:08]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[einbinder, 2017-05-16 02:18:54]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:19:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 03:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 03:47:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2017-05-16 04:16:30]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-05-16 04:16:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 05:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 05:42:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2017-05-16 05:47:24]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-05-16 05:47:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 06:20:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494913644159210,
"parent_rev": "de8bf4e55a221252bfc25b34b4c339c4df1b53a0", "commit_rev":
"6fce1c41322e02c9c1d70bbe1c420ef8269896de"}

[commit-bot: I haz the power, 2017-05-16 06:21:08]

Description was changed from

==========
DevTools: Show product badge in console

BUG=721538
==========

to

==========
DevTools: Show product badge in console

BUG=721538

Review-Url: https://codereview.chromium.org/2879973003
Cr-Commit-Position: refs/heads/master@{#472030}
Committed:
https://chromium.googlesource.com/chromium/src/+/6fce1c41322e02c9c1d70bbe1c42...
==========

[commit-bot: I haz the power, 2017-05-16 06:21:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6fce1c41322e02c9c1d70bbe1c42...