Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2879973003: DevTools: Show product badge in console (Closed)
Patch Set: Merge branch 'master' into badge_final Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index 73c6dd74adfdb4e538caa14244fc508cd61f996e..cc55d6f20c8e07f9b8e0290af3b478deab959c1e 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -136,6 +136,7 @@ Console.ConsoleView = class extends UI.VBox {
this._messagesElement.addEventListener('contextmenu', this._handleContextMenuEvent.bind(this), false);
this._linkifier = new Components.Linkifier();
+ this._badgePool = new ProductRegistry.BadgePool();
/** @type {!Array.<!Console.ConsoleViewMessage>} */
this._consoleMessages = [];
@@ -497,14 +498,14 @@ Console.ConsoleView = class extends UI.VBox {
var nestingLevel = this._currentGroup.nestingLevel();
switch (message.type) {
case ConsoleModel.ConsoleMessage.MessageType.Command:
- return new Console.ConsoleCommand(message, this._linkifier, nestingLevel);
+ return new Console.ConsoleCommand(message, this._linkifier, this._badgePool, nestingLevel);
case ConsoleModel.ConsoleMessage.MessageType.Result:
- return new Console.ConsoleCommandResult(message, this._linkifier, nestingLevel);
+ return new Console.ConsoleCommandResult(message, this._linkifier, this._badgePool, nestingLevel);
case ConsoleModel.ConsoleMessage.MessageType.StartGroupCollapsed:
case ConsoleModel.ConsoleMessage.MessageType.StartGroup:
- return new Console.ConsoleGroupViewMessage(message, this._linkifier, nestingLevel);
+ return new Console.ConsoleGroupViewMessage(message, this._linkifier, this._badgePool, nestingLevel);
default:
- return new Console.ConsoleViewMessage(message, this._linkifier, nestingLevel);
+ return new Console.ConsoleViewMessage(message, this._linkifier, this._badgePool, nestingLevel);
}
}
@@ -515,6 +516,7 @@ Console.ConsoleView = class extends UI.VBox {
this._hidePromptSuggestBox();
this._viewport.setStickToBottom(true);
this._linkifier.reset();
+ this._badgePool.reset();
}
_handleContextMenuEvent(event) {
@@ -1127,10 +1129,11 @@ Console.ConsoleCommand = class extends Console.ConsoleViewMessage {
/**
* @param {!ConsoleModel.ConsoleMessage} message
* @param {!Components.Linkifier} linkifier
+ * @param {!ProductRegistry.BadgePool} badgePool
* @param {number} nestingLevel
*/
- constructor(message, linkifier, nestingLevel) {
- super(message, linkifier, nestingLevel);
+ constructor(message, linkifier, badgePool, nestingLevel) {
+ super(message, linkifier, badgePool, nestingLevel);
}
/**
@@ -1180,10 +1183,11 @@ Console.ConsoleCommandResult = class extends Console.ConsoleViewMessage {
/**
* @param {!ConsoleModel.ConsoleMessage} message
* @param {!Components.Linkifier} linkifier
+ * @param {!ProductRegistry.BadgePool} badgePool
* @param {number} nestingLevel
*/
- constructor(message, linkifier, nestingLevel) {
- super(message, linkifier, nestingLevel);
+ constructor(message, linkifier, badgePool, nestingLevel) {
+ super(message, linkifier, badgePool, nestingLevel);
}
/**
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698