Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

Issue 2879973003: DevTools: Show product badge in console (Closed)
Patch Set: Merge branch 'master' into badge_final Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
diff --git a/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js b/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
index bacfad79353f590a3faca7bfa19994017d09b332..0f0fe7251f71bd8b88413e5d53a225033d30ebd2 100644
--- a/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
+++ b/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
@@ -38,7 +38,8 @@ ProductRegistry.BadgePool = class {
var element = createElement('span');
var root = UI.createShadowRootWithCoreStyles(element, 'product_registry/badge.css');
var badgeElement = root.createChild('span', 'product-registry-badge monospace hidden');
- badgeElement.textContent = ' ';
+ badgeElement.setAttribute('data-initial', ' ');
+ badgeElement.title = '';
badgeElement.addEventListener('mousedown', event => event.consume());
badgeElement.addEventListener('click', event => {
this._showPopup(badgeElement);
@@ -82,7 +83,8 @@ ProductRegistry.BadgePool = class {
var entryName = registry.nameForUrl(parsedUrl);
if (!entryName) {
- badgeElement.textContent = ' ';
+ badgeElement.setAttribute('data-initial', ' ');
+ badgeElement.title = '';
badgeElement.style.removeProperty('background-color');
return;
}
@@ -94,7 +96,8 @@ ProductRegistry.BadgePool = class {
else
label = entryName;
- badgeElement.textContent = label.substring(0, 2).toUpperCase();
+ badgeElement.setAttribute('data-initial', label.substring(0, 2).toUpperCase());
+ badgeElement.title = entryName;
badgeElement.style.backgroundColor = ProductRegistry.BadgePool.colorForEntryName(entryName);
badgeElement.classList.toggle('hidden', !this._setting.get());
}

Powered by Google App Engine
This is Rietveld 408576698