Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 2879413002: Pass NavigationContext to WebStateImpl::OnNavigationStarted. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass NavigationContext to WebStateImpl::OnNavigationStarted. WebStateObserver::ProvisionalNavigationStarted will be renamed to WebStateObserver::DidStartNavigation and will take NavigationContext instead of URL as an argument. This is precursory CL which allows WebStateImpl to have NavigationContext. BUG=713836 Review-Url: https://codereview.chromium.org/2879413002 Cr-Commit-Position: refs/heads/master@{#472585} Committed: https://chromium.googlesource.com/chromium/src/+/b3b1958f43ccd6cbf37a10a4c173b8dbad17cb08

Patch Set 1 #

Patch Set 2 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -32 lines) Patch
M ios/chrome/browser/tabs/tab_unittest.mm View 1 2 chunks +9 lines, -6 lines 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 5 chunks +10 lines, -10 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 3 chunks +8 lines, -9 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/crw_web_ui_manager_unittest.mm View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-15 23:26:40 UTC) #10
Eugene But (OOO till 7-30)
On 2017/05/15 23:26:40, Eugene But wrote: Kurt?
3 years, 7 months ago (2017-05-17 18:23:05 UTC) #11
kkhorimoto
lgtm, sorry for the delay. Loving how these callbacks are getting refactored!
3 years, 7 months ago (2017-05-17 21:04:36 UTC) #12
Eugene But (OOO till 7-30)
On 2017/05/17 21:04:36, kkhorimoto_ wrote: > lgtm, sorry for the delay. Loving how these callbacks ...
3 years, 7 months ago (2017-05-17 21:24:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879413002/20001
3 years, 7 months ago (2017-05-17 21:25:39 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 22:16:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b3b1958f43ccd6cbf37a10a4c173...

Powered by Google App Engine
This is Rietveld 408576698