Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: ios/web/web_state/web_state_impl.mm

Issue 2879413002: Pass NavigationContext to WebStateImpl::OnNavigationStarted. (Closed)
Patch Set: Fixed tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/web_state_impl.h ('k') | ios/web/web_state/web_state_impl_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/web_state_impl.mm
diff --git a/ios/web/web_state/web_state_impl.mm b/ios/web/web_state/web_state_impl.mm
index 387f48707501ac05dcc7bc106fd46370049c374a..f5b23cdedf621d7379065d3fc5651ca4eb061164 100644
--- a/ios/web/web_state/web_state_impl.mm
+++ b/ios/web/web_state/web_state_impl.mm
@@ -670,9 +670,10 @@ bool WebStateImpl::HasOpener() const {
return created_with_opener_;
}
-void WebStateImpl::OnProvisionalNavigationStarted(const GURL& url) {
+void WebStateImpl::OnNavigationStarted(web::NavigationContext* context) {
+ // TODO(crbug.com/713836): pass context to WebStateObserver callback.
for (auto& observer : observers_)
- observer.ProvisionalNavigationStarted(url);
+ observer.ProvisionalNavigationStarted(context->GetUrl());
}
void WebStateImpl::OnNavigationFinished(web::NavigationContext* context) {
« no previous file with comments | « ios/web/web_state/web_state_impl.h ('k') | ios/web/web_state/web_state_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698