ios/web/web_state/web_state_impl_unittest.mm - Issue 2879413002: Pass NavigationContext to WebStateImpl::OnNavigationStarted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/web_state_impl_unittest.mm

Issue 2879413002: Pass NavigationContext to WebStateImpl::OnNavigationStarted. (Closed)

Patch Set: Fixed tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/web_state_impl_unittest.mm

diff --git a/ios/web/web_state/web_state_impl_unittest.mm b/ios/web/web_state/web_state_impl_unittest.mm

index e4c327385f326c4a4d4fa1bfbd427463055f28e9..d4d111e9092037416919f6709a988496601546b9 100644

--- a/ios/web/web_state/web_state_impl_unittest.mm

+++ b/ios/web/web_state/web_state_impl_unittest.mm

@@ -365,7 +365,7 @@ TEST_F(WebStateImplTest, ObserverTest) {

// Test that OnNavigationFinished() is called.

ASSERT_FALSE(observer->start_provisional_navigation_info());

- web_state_->OnProvisionalNavigationStarted(url);

+ web_state_->OnNavigationStarted(context.get());

ASSERT_TRUE(observer->start_provisional_navigation_info());

EXPECT_EQ(web_state_.get(),

observer->start_provisional_navigation_info()->web_state);

« no previous file with comments | « ios/web/web_state/web_state_impl.mm ('k') | ios/web/webui/crw_web_ui_manager_unittest.mm » ('j') | no next file with comments »