Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

This is a preparation for merging Main/ThreadedWorklet into Worklet once both
worklets support module loading.

BUG=627945
Review-Url: https://codereview.chromium.org/2878833002
Cr-Commit-Position: refs/heads/master@{#471263}
Committed: https://chromium.googlesource.com/chromium/src/+/76e63b012333e8446d17e7866f77fb49fc2fc5c3

[nhiroki, 2017-05-12 02:26:14]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[nhiroki, 2017-05-12 02:28:10]

Description was changed from

==========
Worklet: Move common code of addModule from Main/ThraededWorklet to Worklet

BUG=627945
==========

to

==========
Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

BUG=627945
==========

[nhiroki, 2017-05-12 02:29:44]

Description was changed from

==========
Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

BUG=627945
==========

to

==========
Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

This is a preparation for merging Main/ThreadedWorklet into Worklet once both
worklets support module loading.

BUG=627945
==========

[nhiroki, 2017-05-12 02:30:01]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org

[nhiroki, 2017-05-12 02:30:01]

PTAL, thanks!

[kinuko, 2017-05-12 03:45:07]

lgtm % one question

https://codereview.chromium.org/2878833002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/WorkletScriptLoader.h (right):

https://codereview.chromium.org/2878833002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/WorkletScriptLoader.h:47: void
FetchScript(const KURL& module_url_record);
Is the 'module url record' term from the spec?  Naively it feels less clear what
this actually fetches, and if the given parameter is the URL to fetch or not,
but maybe it's clear in worklet terminology?

[nhiroki, 2017-05-12 04:00:16]

Thank you.

https://codereview.chromium.org/2878833002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/WorkletScriptLoader.h (right):

https://codereview.chromium.org/2878833002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/WorkletScriptLoader.h:47: void
FetchScript(const KURL& module_url_record);
On 2017/05/12 03:45:07, kinuko wrote:
> Is the 'module url record' term from the spec?  Naively it feels less clear
what
> this actually fetches, and if the given parameter is the URL to fetch or not,
> but maybe it's clear in worklet terminology?

Yes, it's from the spec:

  "To disambiguate from a valid URL string it can also be referred to as a URL
record."
  (URL spec: https://url.spec.whatwg.org/#concept-url)

  "4. Let moduleURLRecord be the result of parsing the moduleURL argument
relative to outsideSettings."
  (Worklet spec: https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule)

I have no strong opinion on it, but module code owners seem to prefer to align
variable names with spec terms.

[nhiroki, 2017-05-12 04:02:38]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-05-12 04:03:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 05:05:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:05:59]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[nhiroki, 2017-05-12 05:08:36]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:08:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-05-12 06:02:57]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-05-12 06:02:57]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2878833002/#ps20001
(title: "fix crashes")

[commit-bot: I haz the power, 2017-05-12 06:03:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 06:56:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 06:56:31]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nhiroki, 2017-05-12 07:23:55]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-05-12 07:24:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 08:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 08:33:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2017-05-12 08:52:27]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-05-12 08:52:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 09:57:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494579147732850,
"parent_rev": "e982114658f12e1dd021e74580ef7ccd73c44a85", "commit_rev":
"76e63b012333e8446d17e7866f77fb49fc2fc5c3"}

[commit-bot: I haz the power, 2017-05-12 09:57:58]

Description was changed from

==========
Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

This is a preparation for merging Main/ThreadedWorklet into Worklet once both
worklets support module loading.

BUG=627945
==========

to

==========
Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

This is a preparation for merging Main/ThreadedWorklet into Worklet once both
worklets support module loading.

BUG=627945

Review-Url: https://codereview.chromium.org/2878833002
Cr-Commit-Position: refs/heads/master@{#471263}
Committed:
https://chromium.googlesource.com/chromium/src/+/76e63b012333e8446d17e7866f77...
==========

[commit-bot: I haz the power, 2017-05-12 09:57:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76e63b012333e8446d17e7866f77...