Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2868413005: Worklet: Introduce WorkletOptions for addModule() (Closed)

Created:
3 years, 7 months ago by nhiroki
Modified:
3 years, 7 months ago
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Introduce WorkletOptions for addModule() This CL introduces WorkletOptions dictionary for addModule(). This provides "RequestCredentials" option, but it's not actually used yet because module loading part is still under development. Once the module loading is enabled, we'll add layout tests for this option. Spec: https://drafts.css-houdini.org/worklets/#dictdef-workletoptions BUG=710837 TBR=ikilpatrick@chromium.org Review-Url: https://codereview.chromium.org/2868413005 Cr-Commit-Position: refs/heads/master@{#471296} Committed: https://chromium.googlesource.com/chromium/src/+/a3385c2e0f06b3331338de800b014f9ce0086718

Patch Set 1 #

Patch Set 2 : add missing files #

Patch Set 3 : add TODO comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -12 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorklet.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp View 1 2 chunks +23 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorklet.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.h View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/workers/WorkletOptions.idl View 1 2 1 chunk +14 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 24 (15 generated)
nhiroki
PTAL, thanks! +kinuko@ for the entire changes. +yhirano@ for WorkletOptions.idl (see my comment there). https://codereview.chromium.org/2868413005/diff/40001/third_party/WebKit/Source/core/workers/WorkletOptions.idl ...
3 years, 7 months ago (2017-05-12 09:24:46 UTC) #8
yhirano
https://codereview.chromium.org/2868413005/diff/40001/third_party/WebKit/Source/core/workers/WorkletOptions.idl File third_party/WebKit/Source/core/workers/WorkletOptions.idl (right): https://codereview.chromium.org/2868413005/diff/40001/third_party/WebKit/Source/core/workers/WorkletOptions.idl#newcode8 third_party/WebKit/Source/core/workers/WorkletOptions.idl:8: // TODO(nhiroki): Consider how to reuse the existing enum. ...
3 years, 7 months ago (2017-05-12 10:56:35 UTC) #11
kinuko
lgtm
3 years, 7 months ago (2017-05-12 13:02:34 UTC) #12
nhiroki
+ikilpatrick@, let me use TBR for changes under modules/csspaint/PaintWorkletGlobalScopeProxy.* because they just pass a new ...
3 years, 7 months ago (2017-05-12 13:07:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868413005/40001
3 years, 7 months ago (2017-05-12 13:08:17 UTC) #17
haraken
LGTM
3 years, 7 months ago (2017-05-12 13:13:30 UTC) #18
nhiroki
On 2017/05/12 13:13:30, haraken wrote: > LGTM Thank you!
3 years, 7 months ago (2017-05-12 13:14:41 UTC) #19
kouhei (in TOK)
lgtm
3 years, 7 months ago (2017-05-12 13:31:02 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 13:36:52 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a3385c2e0f06b3331338de800b01...

Powered by Google App Engine
This is Rietveld 408576698