Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

third_party/WebKit/Source/core/loader/WorkletScriptLoader.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WorkletScriptLoader_h
 #define WorkletScriptLoader_h
 
 #include "core/CoreExport.h"
 #include "core/loader/resource/ScriptResource.h"
 #include "platform/loader/fetch/ResourceClient.h"
@@ skipping 26 matching lines @@
   };
 
   static WorkletScriptLoader* Create(ResourceFetcher* fetcher, Client* client) {
     return new WorkletScriptLoader(fetcher, client);
   }
 
   ~WorkletScriptLoader() override = default;
 
   // Fetches an URL and loads it as a classic script. Synchronously calls
   // Client::notifyWorkletScriptLoadingFinished() if there is an error.
-  void FetchScript(const String& script_url);
+  void FetchScript(const KURL& module_url_record);

[kinuko, 2017/05/12 03:45:07]

Is the 'module url record' term from the spec?  Naively it feels less clear what
this actually fetches, and if the given parameter is the URL to fetch or not,
but maybe it's clear in worklet terminology?

[nhiroki, 2017/05/12 04:00:16]

Yes, it's from the spec:

  "To disambiguate from a valid URL string it can also be referred to as a URL
record."
  (URL spec: https://url.spec.whatwg.org/#concept-url)

  "4. Let moduleURLRecord be the result of parsing the moduleURL argument
relative to outsideSettings."
  (Worklet spec: https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule)

I have no strong opinion on it, but module code owners seem to prefer to align
variable names with spec terms.

 
   // Cancels resource loading and synchronously calls
   // Client::notifyWorkletScriptLoadingFinished().
   void Cancel();
 
   // Returns true if a script was successfully loaded. This should be called
   // after Client::notifyWorkletScriptLoadingFinished() is called.
   bool WasScriptLoadSuccessful() const;
 
   DECLARE_TRACE();
 
  private:
   WorkletScriptLoader(ResourceFetcher*, Client*);
 
   // ResourceClient
   void NotifyFinished(Resource*) final;
   String DebugName() const final { return "WorkletLoader"; }
 
   Member<ResourceFetcher> fetcher_;
   Member<Client> client_;
 
   bool was_script_load_successful_ = false;
   bool was_script_load_complete_ = false;
 };
 
 }  // namespace blink
 
 #endif  // WorkletScriptLoader_h