Remove unused analysisContext from completion request and contributors

Remove unused analysisContext from completion request and contributors

Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.

R=brianwilkerson@google.com, pquitslund@google.com

Committed: https://github.com/dart-lang/sdk/commit/66bb2d618e1904f94cfd462776c63cf2196a8981

[danrubel, 2017-05-11 03:07:16]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, pquitslund@google.com

[pquitslund, 2017-05-11 03:48:36]

LGTM

A nit but otherwise awesome!

https://codereview.chromium.org/2877653002/diff/1/pkg/analysis_server/test/do...
File pkg/analysis_server/test/domain_completion_test.dart (right):

https://codereview.chromium.org/2877653002/diff/1/pkg/analysis_server/test/do...
pkg/analysis_server/test/domain_completion_test.dart:400: while
(replacementOffset == null) {
Perhaps a note explaining why this is necessary?

[Brian Wilkerson, 2017-05-11 13:56:10]

lgtm

https://codereview.chromium.org/2877653002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/2877653002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_completion.dart:196:
server.resourceProvider.getFile(result.path), result.uri);
It would probably be better to use `File.createSource` rather than `new
FileSource`.

[Brian Wilkerson, 2017-05-11 14:44:35]

Description was changed from

==========
Remove unused analysisContext from completion request and contributors

Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.
==========

to

==========
Remove unused analysisContext from completion request and contributors

Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.
==========

[danrubel, 2017-05-11 16:37:51]

https://codereview.chromium.org/2877653002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/2877653002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_completion.dart:196:
server.resourceProvider.getFile(result.path), result.uri);
On 2017/05/11 13:56:09, Brian Wilkerson wrote:
> It would probably be better to use `File.createSource` rather than `new
> FileSource`.

Done.

https://codereview.chromium.org/2877653002/diff/1/pkg/analysis_server/test/do...
File pkg/analysis_server/test/domain_completion_test.dart (right):

https://codereview.chromium.org/2877653002/diff/1/pkg/analysis_server/test/do...
pkg/analysis_server/test/domain_completion_test.dart:400: while
(replacementOffset == null) {
On 2017/05/11 03:48:36, pquitslund wrote:
> Perhaps a note explaining why this is necessary?

Done.

[danrubel, 2017-05-11 16:38:57]

Description was changed from

==========
Remove unused analysisContext from completion request and contributors

Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.
==========

to

==========
Remove unused analysisContext from completion request and contributors

Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.

R=brianwilkerson@google.com, pquitslund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/66bb2d618e1904f94cfd462776c63cf2196a8981
==========

[danrubel, 2017-05-11 16:38:58]

Committed patchset #2 (id:20001) manually as
66bb2d618e1904f94cfd462776c63cf2196a8981 (presubmit successful).