Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart

Issue 2877653002: Remove unused analysisContext from completion request and contributors (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart b/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart
index a79a63ca92d9eec7744204fdb78cec8546eb2b06..e830a54ab0cdec49203af9a77d1bddac4ef4bb68 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart
@@ -11,7 +11,6 @@ import 'package:analysis_server/src/services/completion/completion_core.dart';
import 'package:analysis_server/src/services/completion/completion_performance.dart';
import 'package:analysis_server/src/services/completion/dart/completion_manager.dart';
import 'package:analysis_server/src/services/completion/dart/imported_reference_contributor.dart';
-import 'package:analyzer/dart/ast/standard_resolution_map.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/task/dart.dart';
import 'package:test/test.dart';
@@ -52,15 +51,9 @@ part '$testFile';
''');
addTestSource('part of libB; main() {^}');
- // Associate part with library
- if (!enableNewAnalysisDriver) {
- context.computeResult(libSource, LIBRARY_CYCLE_UNITS);
- }
-
// Build the request
CompletionRequestImpl baseRequest = new CompletionRequestImpl(
- enableNewAnalysisDriver ? await driver.getResult(testFile) : null,
- enableNewAnalysisDriver ? null : context,
+ await driver.getResult(testFile),
provider,
testSource,
completionOffset,

Powered by Google App Engine
This is Rietveld 408576698