Remove unused analysisContext from completion request and contributors

pkg/analysis_server/lib/src/domain_completion.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library domain.completion;
 
 import 'dart:async';
 
 import 'package:analysis_server/protocol/protocol.dart';
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/domain_abstract.dart';
 import 'package:analysis_server/src/plugin/plugin_manager.dart';
 import 'package:analysis_server/src/plugin/result_converter.dart';
 import 'package:analysis_server/src/provisional/completion/completion_core.dart';
 import 'package:analysis_server/src/services/completion/completion_core.dart';
 import 'package:analysis_server/src/services/completion/completion_performance.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
-import 'package:analyzer/src/generated/engine.dart' hide AnalysisResult;
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/source/source_resource.dart';
 import 'package:analyzer_plugin/protocol/protocol.dart' as plugin;
 import 'package:analyzer_plugin/protocol/protocol_constants.dart' as plugin;
 import 'package:analyzer_plugin/protocol/protocol_generated.dart' as plugin;
 
 /**
  * Instances of the class [CompletionDomainHandler] implement a [RequestHandler]
  * that handles requests in the completion domain.
  */
@@ skipping 132 matching lines @@
   /**
    * Process a `completion.getSuggestions` request.
    */
   Future<Null> processRequest(Request request) async {
     performance = new CompletionPerformance();
 
     // extract and validate params
     CompletionGetSuggestionsParams params =
         new CompletionGetSuggestionsParams.fromRequest(request);
 
-    AnalysisResult result;
-    AnalysisContext context;
-    Source source;
-    if (server.options.enableNewAnalysisDriver) {
-      result = await server.getAnalysisResult(params.file);
+    AnalysisResult result = await server.getAnalysisResult(params.file);
 
-      if (result == null || !result.exists) {
-        if (server.onNoAnalysisCompletion != null) {
-          String completionId = (_nextCompletionId++).toString();
-          await server.onNoAnalysisCompletion(
-              request, this, params, performance, completionId);
-          return;
-        } else {
-          server.sendResponse(new Response.unknownSource(request));
-          return;
-        }
-      }
-
-      if (params.offset < 0 || params.offset > result.content.length) {
-        server.sendResponse(new Response.invalidParameter(
-            request,
-            'params.offset',
-            'Expected offset between 0 and source length inclusive,'
-            ' but found ${params.offset}'));
+    if (result == null || !result.exists) {
+      if (server.onNoAnalysisCompletion != null) {
+        String completionId = (_nextCompletionId++).toString();
+        await server.onNoAnalysisCompletion(
+            request, this, params, performance, completionId);
         return;
-      }
-
-      source = new FileSource(
-          server.resourceProvider.getFile(result.path), result.uri);
-    } else {
-      ContextSourcePair contextSource =
-          server.getContextSourcePair(params.file);
-
-      context = contextSource.context;
-      source = contextSource.source;
-      if (context == null || !context.exists(source)) {
+      } else {
         server.sendResponse(new Response.unknownSource(request));
         return;
       }
-
-      TimestampedData<String> contents = context.getContents(source);
-      if (params.offset < 0 || params.offset > contents.data.length) {
-        server.sendResponse(new Response.invalidParameter(
-            request,
-            'params.offset',
-            'Expected offset between 0 and source length inclusive,'
-            ' but found ${params.offset}'));
-        return;
-      }
     }
 
-    recordRequest(performance, context, source, params.offset);
+    if (params.offset < 0 || params.offset > result.content.length) {
+      server.sendResponse(new Response.invalidParameter(
+          request,
+          'params.offset',
+          'Expected offset between 0 and source length inclusive,'
+          ' but found ${params.offset}'));
+      return;
+    }
+
+    Source source = new FileSource(
+        server.resourceProvider.getFile(result.path), result.uri);

[Brian Wilkerson, 2017/05/11 13:56:09]

It would probably be better to use `File.createSource` rather than `new
FileSource`.

[danrubel, 2017/05/11 16:37:51]

Done.

+
+    recordRequest(performance, source, result.content, params.offset);
 
     CompletionRequestImpl completionRequest = new CompletionRequestImpl(
         result,
-        context,
         server.resourceProvider,
         source,
         params.offset,
         performance,
         server.ideOptions);
 
     String completionId = (_nextCompletionId++).toString();
 
     setNewRequest(completionRequest);
 
@@ skipping 16 matching lines @@
       performance.complete();
     }).whenComplete(() {
       ifMatchesRequestClear(completionRequest);
     });
   }
 
   /**
    * If tracking code completion performance over time, then
    * record addition information about the request in the performance record.
    */
-  void recordRequest(CompletionPerformance performance, AnalysisContext context,
-      Source source, int offset) {
+  void recordRequest(CompletionPerformance performance, Source source,
+      String content, int offset) {
     performance.source = source;
-    if (performanceListMaxLength == 0 || context == null || source == null) {
+    if (performanceListMaxLength == 0 || source == null) {
       return;
     }
-    TimestampedData<String> data = context.getContents(source);
-    if (data == null) {
-      return;
-    }
-    performance.setContentsAndOffset(data.data, offset);
+    performance.setContentsAndOffset(content, offset);
     while (performanceList.length >= performanceListMaxLength) {
       performanceList.removeAt(0);
     }
     performanceList.add(performance);
   }
 
   /**
    * Send completion notification results.
    */
   void sendCompletionNotification(String completionId, int replacementOffset,
@@ skipping 39 matching lines @@
   final int replacementOffset;
 
   /**
    * The suggested completions.
    */
   final List<CompletionSuggestion> suggestions;
 
   CompletionResult(
       this.replacementOffset, this.replacementLength, this.suggestions);
 }