pkg/analysis_server/lib/src/provisional/completion/completion_core.dart - Issue 2877653002: Remove unused analysisContext from completion request and contributors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/completion_core.dart

Issue 2877653002: Remove unused analysisContext from completion request and contributors (Closed)

Patch Set: address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/domain_completion.dart ('k') | pkg/analysis_server/lib/src/services/completion/completion_core.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/provisional/completion/completion_core.dart

diff --git a/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart b/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart

index 6a054ee87ca422ce53a782ec9c82caada9ba9dc2..d4e08f84ef1f7a61fb4cce2329446df7174f1de9 100644

--- a/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart

+++ b/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart

@@ -10,7 +10,6 @@ import 'package:analysis_server/protocol/protocol_generated.dart';

import 'package:analysis_server/src/ide_options.dart';

import 'package:analyzer/file_system/file_system.dart';

import 'package:analyzer/src/dart/analysis/driver.dart';

-import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;

import 'package:analyzer/src/generated/source.dart';

/**

@@ -56,11 +55,6 @@ abstract class CompletionContributor {

abstract class CompletionRequest {

/**

- * Return the analysis context in which the completion is being requested.

- */

- AnalysisContext get context;

- /**

* IDE options for this server instance.

IdeOptions get ideOptions;