Make DragController::DragIsMove return false when selection does not have focus

Make DragController::DragIsMove return false when selection does not have focus

This patch makes the above change so that when dragging with an unfocused
selection, the selection is not considered as the dragging source.

BUG=717453
TEST=editing/selection/drag_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2877623005
Cr-Commit-Position: refs/heads/master@{#471253}
Committed: https://chromium.googlesource.com/chromium/src/+/5fb678a9ee8b5e8e303ea0d66ae5efe979e6fcd2

[Xiaocheng, 2017-05-12 01:06:45]

Description was changed from

==========
Make DragController::DragIsMove return false when selection does not have focus

BUG=
==========

to

==========
Make DragController::DragIsMove return false when selection does not have focus

This patch makes the above change so that when dragging with an unfocused
selection, the selection is not considered as the dragging source.

BUG=717453
==========

[Xiaocheng, 2017-05-12 01:06:55]

Description was changed from

==========
Make DragController::DragIsMove return false when selection does not have focus

This patch makes the above change so that when dragging with an unfocused
selection, the selection is not considered as the dragging source.

BUG=717453
==========

to

==========
Make DragController::DragIsMove return false when selection does not have focus

This patch makes the above change so that when dragging with an unfocused
selection, the selection is not considered as the dragging source.

BUG=717453
TEST=editing/selection/drag_with_unfocused_selection.html
==========

[Xiaocheng, 2017-05-12 01:06:58]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 01:07:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 02:48:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 02:48:46]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-05-12 03:03:41]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-12 03:03:41]

PTAL.

[yosin_UTC9, 2017-05-12 03:52:51]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-05-12 03:52:52]

lgtm

+tkent@ for OWNERS review.

[yosin_UTC9, 2017-05-12 04:05:45]

https://codereview.chromium.org/2877623005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/drag_with_unfocused_selection.html
(right):

https://codereview.chromium.org/2877623005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/drag_with_unfocused_selection.html:16:
assert_not_equals(window.eventSender, 'This test requires eventSender');
Let's use |assert_exists(window, 'eventSender');|

https://codereview.chromium.org/2877623005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/drag_with_unfocused_selection.html:47:
[
nit: Please have two spaces indentation.

https://codereview.chromium.org/2877623005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/drag_with_unfocused_selection.html:72:
assert_not_equals(window.eventSender, 'This test requires eventSender');
Let's use |assert_exists(window, 'eventSender');|

https://codereview.chromium.org/2877623005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/drag_with_unfocused_selection.html:75:
[
nit: Please have two spaces indentation.

[tkent, 2017-05-12 04:58:40]

lgtm

[yosin_UTC9, 2017-05-12 08:42:37]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-05-12 08:43:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 09:03:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494578557728480,
"parent_rev": "444081d02babdf1867ee41f5633502f6c325d9f2", "commit_rev":
"5fb678a9ee8b5e8e303ea0d66ae5efe979e6fcd2"}

[commit-bot: I haz the power, 2017-05-12 09:03:16]

Description was changed from

==========
Make DragController::DragIsMove return false when selection does not have focus

This patch makes the above change so that when dragging with an unfocused
selection, the selection is not considered as the dragging source.

BUG=717453
TEST=editing/selection/drag_with_unfocused_selection.html
==========

to

==========
Make DragController::DragIsMove return false when selection does not have focus

This patch makes the above change so that when dragging with an unfocused
selection, the selection is not considered as the dragging source.

BUG=717453
TEST=editing/selection/drag_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2877623005
Cr-Commit-Position: refs/heads/master@{#471253}
Committed:
https://chromium.googlesource.com/chromium/src/+/5fb678a9ee8b5e8e303ea0d66ae5...
==========

[commit-bot: I haz the power, 2017-05-12 09:03:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5fb678a9ee8b5e8e303ea0d66ae5...