third_party/WebKit/Source/core/page/DragController.cpp - Issue 2877623005: Make DragController::DragIsMove return false when selection does not have focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 2877623005: Make DragController::DragIsMove return false when selection does not have focus (Closed)

Patch Set: Add layout test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/DragController.cpp

diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp

index 5283c0e7cc1b807a4e5f9a247b4be2b2542417f9..8d4750d96ddbe8998be606acf1f10a699bcead2a 100644

--- a/third_party/WebKit/Source/core/page/DragController.cpp

+++ b/third_party/WebKit/Source/core/page/DragController.cpp

@@ -200,6 +200,7 @@ static DocumentFragment* DocumentFragmentFromDragData(

bool DragController::DragIsMove(FrameSelection& selection,

DragData* drag_data) {

return document_under_mouse_ == drag_initiator_ &&

+ selection.SelectionHasFocus() &&

selection.ComputeVisibleSelectionInDOMTreeDeprecated()

.IsContentEditable() &&

selection.ComputeVisibleSelectionInDOMTreeDeprecated().IsRange() &&