Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2872133011: Change deprecation message of eventSender from error to warning (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
dtapuska, lanwei, tdresser
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change deprecation message of eventSender to warning Replacing eventSender by pointerActionSequence is not trivial. The deprecation message should be a warning, so that CLs with eventSender can be at least uploaded for reference or discussion purposes. BUG=n/a Review-Url: https://codereview.chromium.org/2872133011 Cr-Commit-Position: refs/heads/master@{#471159} Committed: https://chromium.googlesource.com/chromium/src/+/57a05b2e60d3c0090ff1f158f7b71ea46efaa671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Xiaocheng
PTAL. I tried for a few hours but still haven't managed to perform a drag-and-drop ...
3 years, 7 months ago (2017-05-11 23:45:40 UTC) #5
lanwei
On 2017/05/11 23:45:40, Xiaocheng wrote: > PTAL. > > I tried for a few hours ...
3 years, 7 months ago (2017-05-12 00:37:18 UTC) #6
Xiaocheng
Thanks for reviewing!
3 years, 7 months ago (2017-05-12 00:59:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133011/1
3 years, 7 months ago (2017-05-12 01:00:00 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 01:10:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/57a05b2e60d3c0090ff1f158f7b7...

Powered by Google App Engine
This is Rietveld 408576698