Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2876403002: Move WebInputEventConversion from web/ to core/events/. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebInputEventConversion from web/ to core/events/. Update all include sites, and remove some unused includes from WebFrameWidgetBase.cpp. BUG=708879 Review-Url: https://codereview.chromium.org/2876403002 Cr-Commit-Position: refs/heads/master@{#471734} Committed: https://chromium.googlesource.com/chromium/src/+/74a65b727dde1c671f3269da7605093fe7b72247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -522 lines) Patch
M third_party/WebKit/Source/core/events/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/events/WebInputEventConversion.h View 5 chunks +13 lines, -14 lines 0 comments Download
A + third_party/WebKit/Source/core/events/WebInputEventConversion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlayAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImplTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/web/WebInputEventConversion.h View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 chunk +0 lines, -381 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
slangley
3 years, 7 months ago (2017-05-15 07:28:30 UTC) #2
dcheng
lgtm
3 years, 7 months ago (2017-05-15 07:37:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876403002/1
3 years, 7 months ago (2017-05-15 09:56:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/74a65b727dde1c671f3269da7605093fe7b72247
3 years, 7 months ago (2017-05-15 12:19:57 UTC) #8
tkent
IMO, WebInputEventConversion should be in core/input, not core/events.
3 years, 7 months ago (2017-05-15 22:45:55 UTC) #9
slangley
sg - Will move it On Tue, May 16, 2017 at 8:45 AM, <tkent@chromium.org> wrote: ...
3 years, 7 months ago (2017-05-16 11:15:41 UTC) #10
slangley
3 years, 7 months ago (2017-05-16 11:15:41 UTC) #11
Message was sent while issue was closed.
sg - Will move it

On Tue, May 16, 2017 at 8:45 AM, <tkent@chromium.org> wrote:

> IMO, WebInputEventConversion should be in core/input, not core/events.
>
>
> https://codereview.chromium.org/2876403002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698