Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2877363002: Move more classes over to use WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
sashab, dcheng
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, kinuko+watch, kinuko+fileapi, mlamouri+watch-blink_chromium.org, nhiroki, Srirama, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more classes over to use WebLocalFrameBase instead of WebLocalFrameImpl. Classes changed were: - ColorChooserUIController - ExternalPopupMenu. - IndexedDBClientImpl. - InspectorEmulationAgent. - LocalFileSystemClient. - NavigatorContentUtilsClientImpl. - PageOverlay. - RemoteFrameOwner. - StorageQuotaClientImpl. - TextCheckerClientImpl. - UserMediaClientImpl - WebHelperPluginImpl In some cases it may be possible to now move files out of web/ altogether, I will do this in follow up CLs. BUG=708879 Review-Url: https://codereview.chromium.org/2877363002 Cr-Commit-Position: refs/heads/master@{#471687} Committed: https://chromium.googlesource.com/chromium/src/+/f325f36981d3529186e42faf140b72f064b39557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -48 lines) Patch
M third_party/WebKit/Source/web/ColorChooserUIController.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/IndexedDBClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFileSystemClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/NavigatorContentUtilsClientImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/NavigatorContentUtilsClientImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/StorageQuotaClientImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/TextCheckerClientImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/TextCheckerClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
slangley
3 years, 7 months ago (2017-05-15 02:48:31 UTC) #3
sashab
lgtm
3 years, 7 months ago (2017-05-15 02:59:07 UTC) #5
slangley
dcheng@ - ptal
3 years, 7 months ago (2017-05-15 03:42:24 UTC) #7
dcheng
LGTM
3 years, 7 months ago (2017-05-15 04:11:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877363002/1
3 years, 7 months ago (2017-05-15 07:07:07 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 07:12:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f325f36981d3529186e42faf140b...

Powered by Google App Engine
This is Rietveld 408576698