Cleanup: Remove some unneeded Extension* class forward declarations.

Cleanup: Remove some unneeded Extension* class forward declarations.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271588

[Lei Zhang, 2014-05-14 18:03:30]

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/su...
File chrome/browser/extensions/suspicious_extension_bubble_controller.h (left):

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/su...
chrome/browser/extensions/suspicious_extension_bubble_controller.h:19: namespace
{
what the heck is this doing here?

[not at google - send to devlin, 2014-05-14 18:06:23]

I'll let finnur take this one, since that question is for him, so he might as
well review the rest too.

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/su...
File chrome/browser/extensions/suspicious_extension_bubble_controller.h (left):

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/su...
chrome/browser/extensions/suspicious_extension_bubble_controller.h:19: namespace
{
On 2014/05/14 18:03:30, Lei Zhang wrote:
> what the heck is this doing here?

wow what...

[Finnur, 2014-05-15 11:32:40]

Thanks for the cleanup. It LGTM, once one thing has been addressed (see below).

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/su...
File chrome/browser/extensions/suspicious_extension_bubble_controller.h (left):

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/su...
chrome/browser/extensions/suspicious_extension_bubble_controller.h:19: namespace
{
Adding the anonymous namespace was a late request (from Ben) in a re-factor CL
and it looks like I forgot to move this to the .cc file at the same time. You
can see it got moved in subsequent bubbles (SettingsAPI, ie.)

Note: The same applies to the DevMode bubble (dev_mode_bubble_controller.h), as
that class is a copy of this. It should therefore also have this moved to the
.cc file and similar modifications made to it (as the ones made here).

[Finnur, 2014-05-15 11:33:32]

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/nt...
File chrome/browser/extensions/ntp_overridden_bubble_controller.h (right):

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/nt...
chrome/browser/extensions/ntp_overridden_bubble_controller.h:8: #include
<string>
This can be removed now also.

[Lei Zhang, 2014-05-20 00:17:07]

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/nt...
File chrome/browser/extensions/ntp_overridden_bubble_controller.h (right):

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/nt...
chrome/browser/extensions/ntp_overridden_bubble_controller.h:8: #include
<string>
On 2014/05/15 11:33:33, Finnur wrote:
> This can be removed now also.

But we use std::string on line 20.

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/su...
File chrome/browser/extensions/suspicious_extension_bubble_controller.h (left):

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/su...
chrome/browser/extensions/suspicious_extension_bubble_controller.h:19: namespace
{
On 2014/05/15 11:32:41, Finnur wrote:
> Adding the anonymous namespace was a late request (from Ben) in a re-factor CL
> and it looks like I forgot to move this to the .cc file at the same time. You
> can see it got moved in subsequent bubbles (SettingsAPI, ie.)
> 
> Note: The same applies to the DevMode bubble (dev_mode_bubble_controller.h),
as
> that class is a copy of this. It should therefore also have this moved to the
> .cc file and similar modifications made to it (as the ones made here).

Done.

[Lei Zhang, 2014-05-20 00:25:41]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-20 00:25:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/287623005/40001

[commit-bot: I haz the power, 2014-05-20 02:26:28]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Lei Zhang, 2014-05-20 02:27:43]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-05-20 02:32:14]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-20 02:33:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/287623005/60001

[commit-bot: I haz the power, 2014-05-20 04:27:10]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-20 06:25:35]

Change committed as 271588

[Finnur, 2014-05-20 11:52:24]

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/nt...
File chrome/browser/extensions/ntp_overridden_bubble_controller.h (right):

https://codereview.chromium.org/287623005/diff/1/chrome/browser/extensions/nt...
chrome/browser/extensions/ntp_overridden_bubble_controller.h:8: #include
<string>
Good point. Missed that during my scanning of the file.