Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5302)

Unified Diff: chrome/browser/extensions/dev_mode_bubble_controller.h

Issue 287623005: Cleanup: Remove some unneeded Extension* class forward declarations. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: pass presubmit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/dev_mode_bubble_controller.h
===================================================================
--- chrome/browser/extensions/dev_mode_bubble_controller.h (revision 270499)
+++ chrome/browser/extensions/dev_mode_bubble_controller.h (working copy)
@@ -6,61 +6,15 @@
#define CHROME_BROWSER_EXTENSIONS_DEV_MODE_BUBBLE_CONTROLLER_H_
#include <string>
+
#include "chrome/browser/extensions/extension_message_bubble_controller.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
-#include "extensions/common/extension.h"
-class Browser;
-class ExtensionService;
-
namespace extensions {
-namespace {
+class Extension;
-class DevModeBubbleDelegate
- : public ExtensionMessageBubbleController::Delegate {
+class DevModeBubbleController : public ExtensionMessageBubbleController {
public:
- explicit DevModeBubbleDelegate(Profile* profile);
- virtual ~DevModeBubbleDelegate();
-
- // ExtensionMessageBubbleController::Delegate methods.
- virtual bool ShouldIncludeExtension(const std::string& extension_id) OVERRIDE;
- virtual void AcknowledgeExtension(
- const std::string& extension_id,
- ExtensionMessageBubbleController::BubbleAction user_action) OVERRIDE;
- virtual void PerformAction(const ExtensionIdList& list) OVERRIDE;
- virtual void OnClose() OVERRIDE;
- virtual base::string16 GetTitle() const OVERRIDE;
- virtual base::string16 GetMessageBody() const OVERRIDE;
- virtual base::string16 GetOverflowText(
- const base::string16& overflow_count) const OVERRIDE;
- virtual base::string16 GetLearnMoreLabel() const OVERRIDE;
- virtual GURL GetLearnMoreUrl() const OVERRIDE;
- virtual base::string16 GetActionButtonLabel() const OVERRIDE;
- virtual base::string16 GetDismissButtonLabel() const OVERRIDE;
- virtual bool ShouldShowExtensionList() const OVERRIDE;
- virtual void LogExtensionCount(size_t count) OVERRIDE;
- virtual void LogAction(
- ExtensionMessageBubbleController::BubbleAction action) OVERRIDE;
-
- private:
- // The associated profile (weak).
- Profile* profile_;
-
- // Our extension service. Weak, not owned by us.
- ExtensionService* service_;
-
- DISALLOW_COPY_AND_ASSIGN(DevModeBubbleDelegate);
-};
-
-} // namespace
-
-class DevModeBubble;
-
-class DevModeBubbleController
- : public ExtensionMessageBubbleController {
- public:
// Clears the list of profiles the bubble has been shown for. Should only be
// used during testing.
static void ClearProfileListForTesting();
« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api.h ('k') | chrome/browser/extensions/dev_mode_bubble_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698