Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/extensions/ntp_overridden_bubble_controller.h

Issue 287623005: Cleanup: Remove some unneeded Extension* class forward declarations. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_NTP_OVERRIDDEN_BUBBLE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_NTP_OVERRIDDEN_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_NTP_OVERRIDDEN_BUBBLE_CONTROLLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_NTP_OVERRIDDEN_BUBBLE_CONTROLLER_H_
7 7
8 #include <string> 8 #include <string>
Finnur 2014/05/15 11:33:33 This can be removed now also.
Lei Zhang 2014/05/20 00:17:08 But we use std::string on line 20.
Finnur 2014/05/20 11:52:25 Good point. Missed that during my scanning of the
9 #include "chrome/browser/extensions/extension_message_bubble_controller.h" 9 #include "chrome/browser/extensions/extension_message_bubble_controller.h"
10 10
11 class ExtensionService;
12
13 namespace extensions { 11 namespace extensions {
14 12
15 class NtpOverriddenBubbleController : public ExtensionMessageBubbleController { 13 class NtpOverriddenBubbleController : public ExtensionMessageBubbleController {
16 public: 14 public:
17 explicit NtpOverriddenBubbleController(Profile* profile); 15 explicit NtpOverriddenBubbleController(Profile* profile);
18 virtual ~NtpOverriddenBubbleController(); 16 virtual ~NtpOverriddenBubbleController();
19 17
20 // Whether the controller knows that we should show the bubble for extension 18 // Whether the controller knows that we should show the bubble for extension
21 // with |extension_id|. Returns true if so. 19 // with |extension_id|. Returns true if so.
22 bool ShouldShow(const std::string& extension_id); 20 bool ShouldShow(const std::string& extension_id);
23 21
24 // ExtensionMessageBubbleController: 22 // ExtensionMessageBubbleController:
25 virtual bool CloseOnDeactivate() OVERRIDE; 23 virtual bool CloseOnDeactivate() OVERRIDE;
26 24
27 private: 25 private:
28 // A weak pointer to the profile we are associated with. Not owned by us. 26 // A weak pointer to the profile we are associated with. Not owned by us.
29 Profile* profile_; 27 Profile* profile_;
30 28
31 DISALLOW_COPY_AND_ASSIGN(NtpOverriddenBubbleController); 29 DISALLOW_COPY_AND_ASSIGN(NtpOverriddenBubbleController);
32 }; 30 };
33 31
34 } // namespace extensions 32 } // namespace extensions
35 33
36 #endif // CHROME_BROWSER_EXTENSIONS_NTP_OVERRIDDEN_BUBBLE_CONTROLLER_H_ 34 #endif // CHROME_BROWSER_EXTENSIONS_NTP_OVERRIDDEN_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698