Cleanup: Remove some unneeded Extension* class forward declarations.

chrome/browser/extensions/suspicious_extension_bubble_controller.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_SUSPICIOUS_EXTENSION_BUBBLE_CONTROLLER_H_
 #define CHROME_BROWSER_EXTENSIONS_SUSPICIOUS_EXTENSION_BUBBLE_CONTROLLER_H_
 
-#include <string>
+#include "chrome/browser/extensions/extension_message_bubble_controller.h"
 
-#include "chrome/browser/extensions/extension_message_bubble_controller.h"
-#include "extensions/common/extension.h"
-
-class Browser;
-class ExtensionService;
 class Profile;
 
-using extensions::ExtensionMessageBubbleController;
-
-namespace {

[Lei Zhang, 2014/05/14 18:03:30]

what the heck is this doing here?

[not at google - send to devlin, 2014/05/14 18:06:24]

wow what...

[Finnur, 2014/05/15 11:32:41]

Adding the anonymous namespace was a late request (from Ben) in a re-factor CL
and it looks like I forgot to move this to the .cc file at the same time. You
can see it got moved in subsequent bubbles (SettingsAPI, ie.)

Note: The same applies to the DevMode bubble (dev_mode_bubble_controller.h), as
that class is a copy of this. It should therefore also have this moved to the
.cc file and similar modifications made to it (as the ones made here).

[Lei Zhang, 2014/05/20 00:17:08]

Done.

-
-class SuspiciousExtensionBubbleDelegate
-    : public ExtensionMessageBubbleController::Delegate {
- public:
-  explicit SuspiciousExtensionBubbleDelegate(Profile* profile);
-  virtual ~SuspiciousExtensionBubbleDelegate();
-
-  // ExtensionMessageBubbleController::Delegate methods.
-  virtual bool ShouldIncludeExtension(const std::string& extension_id) OVERRIDE;
-  virtual void AcknowledgeExtension(
-      const std::string& extension_id,
-      ExtensionMessageBubbleController::BubbleAction user_action) OVERRIDE;
-  virtual void PerformAction(const extensions::ExtensionIdList& list) OVERRIDE;
-  virtual base::string16 GetTitle() const OVERRIDE;
-  virtual base::string16 GetMessageBody() const OVERRIDE;
-  virtual base::string16 GetOverflowText(
-      const base::string16& overflow_count) const OVERRIDE;
-  virtual base::string16 GetLearnMoreLabel() const OVERRIDE;
-  virtual GURL GetLearnMoreUrl() const OVERRIDE;
-  virtual base::string16 GetActionButtonLabel() const OVERRIDE;
-  virtual base::string16 GetDismissButtonLabel() const OVERRIDE;
-  virtual bool ShouldShowExtensionList() const OVERRIDE;
-  virtual void LogExtensionCount(size_t count) OVERRIDE;
-  virtual void LogAction(
-      ExtensionMessageBubbleController::BubbleAction action) OVERRIDE;
-
- private:
-  // Our profile. Weak, not owned by us.
-  Profile* profile_;
-
-  DISALLOW_COPY_AND_ASSIGN(SuspiciousExtensionBubbleDelegate);
-};
-
-}  // namespace
-
 namespace extensions {
 
 class SuspiciousExtensionBubble;
 
 class SuspiciousExtensionBubbleController
-    : public ExtensionMessageBubbleController {
+    : public extensions::ExtensionMessageBubbleController {
  public:
   // Clears the list of profiles the bubble has been shown for. Should only be
   // used during testing.
   static void ClearProfileListForTesting();
 
   explicit SuspiciousExtensionBubbleController(Profile* profile);
   virtual ~SuspiciousExtensionBubbleController();
 
   // Whether the controller knows of extensions to list in the bubble. Returns
   // true if so.
   bool ShouldShow();
 
   // ExtensionMessageBubbleController methods.
   virtual void Show(ExtensionMessageBubble* bubble) OVERRIDE;
 
  private:
   // A weak pointer to the profile we are associated with. Not owned by us.
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(SuspiciousExtensionBubbleController);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_SUSPICIOUS_EXTENSION_BUBBLE_CONTROLLER_H_