Add missing IWYU message_loop.h includes.

Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n *[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])', re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content, "base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromium.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2876013002
Cr-Commit-Position: refs/heads/master@{#471412}
Committed: https://chromium.googlesource.com/chromium/src/+/f64a25e32afb6f3fd7141cdf589b402290fee16a

[gab, 2017-05-11 18:36:31]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[gab, 2017-05-11 18:36:33]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-11 18:36:38]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-11 18:36:44]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-11 18:48:01]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if 'std::unique_ptr<base::MessageLoop>' in match:
        return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  found = False
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop>' in match:
        found = True
        break
  if not found:
    return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-11 19:16:59]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in first pass...
  found = False
  if '.h' is os.path.splitext(file_path)[1]:
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop>' in match:
        found = True
        break
  if not found:
    return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop\w*[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-12 13:30:46]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'\n( )*[^/\n][^/\n][^/\n]*base::MessageLoop\w*[^\*]',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if '.h' is os.path.splitext(file_path)[1]:
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n
*[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-12 13:31:23]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n
*[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n
*[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromium.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-12 13:31:25]

gab@chromium.org changed reviewers:
+ fdoray@chromium.org

[gab, 2017-05-12 13:32:05]

Francois PTaL, I'm TBRing self to land.

[gab, 2017-05-12 13:36:20]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-12 13:36:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 13:45:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 13:45:37]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[mthiesse1, 2017-05-12 14:33:25]

mthiesse@google.com changed reviewers:
+ mthiesse@google.com

[mthiesse1, 2017-05-12 14:33:28]

vr_shell lgtm

[gab, 2017-05-12 14:36:17]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n
*[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromium.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n
*[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromium.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[gab, 2017-05-12 14:36:36]

The CQ bit was checked by gab@chromium.org

[gab, 2017-05-12 14:36:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mthiesse@google.com
Link to the patchset: https://codereview.chromium.org/2876013002/#ps60001
(title: "rebase on r471297")

[commit-bot: I haz the power, 2017-05-12 14:37:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 14:37:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 14:37:29]

Your CL can not be processed by CQ because of:
 * target_ref must start with "refs/".
   Hint: re-upload your CL with proper --target_branch or omit --target_branch
argument entirely

[gab, 2017-05-12 14:49:14]

The CQ bit was checked by gab@chromium.org

[gab, 2017-05-12 14:49:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mthiesse@google.com
Link to the patchset: https://codereview.chromium.org/2876013002/#ps80001
(title: "fix upstream")

[commit-bot: I haz the power, 2017-05-12 14:49:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-12 14:50:12]

lgtm

[mthiesse, 2017-05-12 15:11:11]

mthiesse@chromium.org changed reviewers:
+ mthiesse@chromium.org
- mthiesse@google.com

[mthiesse, 2017-05-12 15:11:13]

lgtm from the correct account

[commit-bot: I haz the power, 2017-05-12 17:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 17:22:51]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scheib, 2017-05-12 17:27:05]

scheib@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2017-05-12 17:27:08]

device lgtm

[gab, 2017-05-12 18:04:28]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-12 18:06:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 19:43:02]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494612268198560,
"parent_rev": "3368046332ce701e1aab8b4e34b1eb27685cada3", "commit_rev":
"6f4702e1510cf1faacac827f2c6df68c8cefd061"}

[commit-bot: I haz the power, 2017-05-12 19:43:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494612268198560,
"parent_rev": "cfc46a6fe55792b4e5ed1255991355953131d39e", "commit_rev":
"f64a25e32afb6f3fd7141cdf589b402290fee16a"}

[commit-bot: I haz the power, 2017-05-12 19:43:39]

Description was changed from

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n
*[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromium.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing IWYU message_loop.h includes.

This is a pre-req to removing the dependency from RunLoop->MessageLoop
as many files only include run_loop.h but instantiate a MessageLoop.

The following fix script was applied to each file in the codebase
(plus a few hand fixes for DEPS and for //base):

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class MessageLoop;' in content:
    return False
  if 'class MessageLoopForUI;' in content:
    return False
  if 'class MessageLoopForIO;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(\n
*[^/\n][^/\n][^/\n]*base::MessageLoop(ForUI|ForIO)?\b[^*])',
re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore unique pointers in headers in first pass...
  if os.path.splitext(file_path)[1] == '.h':
    found = False
    for match in matches:
      if not 'std::unique_ptr<base::MessageLoop' in match[0]:
        found = True
        break
    if not found:
      return False

  updated_content = refactor_lib.AddInclude(file_path, content,
"base/message_loop/message_loop.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromium.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2876013002
Cr-Commit-Position: refs/heads/master@{#471412}
Committed:
https://chromium.googlesource.com/chromium/src/+/f64a25e32afb6f3fd7141cdf589b...
==========

[commit-bot: I haz the power, 2017-05-12 19:43:45]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f64a25e32afb6f3fd7141cdf589b...

[Do not use (sergeyu), 2017-05-16 00:20:43]

sergeyu@google.com changed reviewers:
+ sergeyu@google.com

[Do not use (sergeyu), 2017-05-16 00:20:46]

https://codereview.chromium.org/2876013002/diff/80001/remoting/base/auto_thre...
File remoting/base/auto_thread_unittest.cc (right):

https://codereview.chromium.org/2876013002/diff/80001/remoting/base/auto_thre...
remoting/base/auto_thread_unittest.cc:5: #include "remoting/base/auto_thread.h"
includes order is wrong here

[gab, 2017-05-16 14:12:50]

https://codereview.chromium.org/2876013002/diff/80001/remoting/base/auto_thre...
File remoting/base/auto_thread_unittest.cc (right):

https://codereview.chromium.org/2876013002/diff/80001/remoting/base/auto_thre...
remoting/base/auto_thread_unittest.cc:5: #include "remoting/base/auto_thread.h"
On 2017/05/16 00:20:46, Do not use (sergeyu) wrote:
> includes order is wrong here

No it's not, this is git cl format's output.

The matching foo.h header for foo.cc and foo_unittest.cc goes at the top.

In general there should also be a newline but this isn't against style and is
the current output of git cl format (and one-off fixing includes in mass
refactorings isn't going to happen: http://crbug.com/710164 is up for clang team
to address this prefered chromium style).