Make sure that run_command_with_output also capture the command stderr

Make sure that run_command_with_output also capture the command stderr

I am suspecting this is making run_gtest_perf_test wrapper script failing to
capture the numerical data of C++ perf test (See
https://bugs.chromium.org/p/chromium/issues/detail?id=715565#c13)

BUG=715565
Review-Url: https://codereview.chromium.org/2875843002
Cr-Commit-Position: refs/heads/master@{#470778}
Committed: https://chromium.googlesource.com/chromium/src/+/55cc689a360554c57326bd642a21d5bd1f4a2c66

[nednguyen, 2017-05-11 00:02:33]

nednguyen@google.com changed reviewers:
+ dpranke@chromium.org, iannucci@chromium.org

[nednguyen, 2017-05-11 00:02:38]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[nednguyen, 2017-05-11 00:03:09]

https://codereview.chromium.org/2875843002/diff/1/testing/scripts/common.py
File testing/scripts/common.py (right):

https://codereview.chromium.org/2875843002/diff/1/testing/scripts/common.py#n...
testing/scripts/common.py:73: def run_command_with_output(argv, env=None,
cwd=None, stdoutfile=None):
This is used in run_gtest_perf_test
(https://cs.chromium.org/chromium/src/testing/scripts/run_gtest_perf_test.py?d...)

[commit-bot: I haz the power, 2017-05-11 00:05:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-05-11 01:52:21]

Seems like a good idea. Let's see if it breaks anything :).

[Dirk Pranke, 2017-05-11 01:52:31]

lgtm.

[nednguyen(REVIEW IN OTHER ACC), 2017-05-11 02:24:56]

The CQ bit was unchecked by nednguyen@chromium.org

[nednguyen(REVIEW IN OTHER ACC), 2017-05-11 02:25:00]

The CQ bit was checked by nednguyen@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:25:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 02:36:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494469500784800, "parent_rev":
"9b7900b2523e1849e18e0e77388466d465e84263", "commit_rev":
"55cc689a360554c57326bd642a21d5bd1f4a2c66"}

[commit-bot: I haz the power, 2017-05-11 02:36:13]

Description was changed from

==========
Make sure that run_command_with_output also capture the command stderr

I am suspecting this is making run_gtest_perf_test wrapper script failing to
capture the numerical data of C++ perf test (See
https://bugs.chromium.org/p/chromium/issues/detail?id=715565#c13)

BUG=715565
==========

to

==========
Make sure that run_command_with_output also capture the command stderr

I am suspecting this is making run_gtest_perf_test wrapper script failing to
capture the numerical data of C++ perf test (See
https://bugs.chromium.org/p/chromium/issues/detail?id=715565#c13)

BUG=715565

Review-Url: https://codereview.chromium.org/2875843002
Cr-Commit-Position: refs/heads/master@{#470778}
Committed:
https://chromium.googlesource.com/chromium/src/+/55cc689a360554c57326bd642a21...
==========

[commit-bot: I haz the power, 2017-05-11 02:36:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55cc689a360554c57326bd642a21...