Make sure that run_command_with_output also capture the command stderr

testing/scripts/common.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import contextlib
 import json
 import os
 import subprocess
 import sys
@@ skipping 52 matching lines @@
   return args.func(args)
 
 
 def run_command(argv, env=None, cwd=None):
   print 'Running %r in %r (env: %r)' % (argv, cwd, env)
   rc = subprocess.call(argv, env=env, cwd=cwd)
   print 'Command %r returned exit code %d' % (argv, rc)
   return rc
 
 
 def run_command_with_output(argv, env=None, cwd=None, stdoutfile=None):

[nednguyen, 2017/05/11 00:03:09]

This is used in run_gtest_perf_test
(https://cs.chromium.org/chromium/src/testing/scripts/run_gtest_perf_test.py?d...)

   print 'Running %r in %r (env: %r)' % (argv, cwd, env)
   rc = 1
   try:
-    output = subprocess.check_output(argv, env=env, cwd=cwd)
+    output = subprocess.check_output(argv, env=env, cwd=cwd,
+        stderr=subprocess.STDOUT)
     if stdoutfile:
       with open(stdoutfile, 'w') as fp:
         fp.write(output)
     rc = 0
   except Exception:
     # Exit code remains 1 and we don't write output
     pass
   print 'Command %r returned exit code %d' % (argv, rc)
   return rc
 
@@ skipping 91 matching lines @@
       [sys.executable, script_to_run] + extra_args)
 
   with open(log_file) as f:
     failures = json.load(f)
   json.dump({
       'valid': integration_test_res == 0,
       'failures': failures,
   }, output)
 
   return integration_test_res