testing/scripts/common.py - Issue 2875843002: Make sure that run_command_with_output also capture the command stderr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/scripts/common.py

Issue 2875843002: Make sure that run_command_with_output also capture the command stderr (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/scripts/common.py

diff --git a/testing/scripts/common.py b/testing/scripts/common.py

index f3407767f3d52e6df1e81ea53371d62075a9df28..d366fe15b24e9d95c922b17441704f76167963a4 100644

--- a/testing/scripts/common.py

+++ b/testing/scripts/common.py

@@ -74,7 +74,8 @@ def run_command_with_output(argv, env=None, cwd=None, stdoutfile=None):

print 'Running %r in %r (env: %r)' % (argv, cwd, env)

rc = 1

try:

- output = subprocess.check_output(argv, env=env, cwd=cwd)

+ output = subprocess.check_output(argv, env=env, cwd=cwd,

+ stderr=subprocess.STDOUT)

if stdoutfile:

with open(stdoutfile, 'w') as fp:

fp.write(output)

« no previous file with comments | « no previous file | no next file » | no next file with comments »