Sort suites in suite table based on number of failed test cases.

Sort suites in suite table based on number of failed test cases.

We want to show suites that have failed test cases at the top of the
suite table, by default.

BUG=720382
Review-Url: https://codereview.chromium.org/2875803004
Cr-Commit-Position: refs/heads/master@{#471534}
Committed: https://chromium.googlesource.com/chromium/src/+/ad4f5792cb064c721831860a180e4f25f99cf186

[BigBossZhiling, 2017-05-11 21:13:44]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-05-11 23:07:57]

jbudorick@chromium.org changed reviewers:
+ yolandyan@chromium.org

[jbudorick, 2017-05-11 23:07:57]

https://codereview.chromium.org/2875803004/diff/20001/build/android/pylib/res...
File build/android/pylib/results/presentation/test_results_presentation.py
(right):

https://codereview.chromium.org/2875803004/diff/20001/build/android/pylib/res...
build/android/pylib/results/presentation/test_results_presentation.py:252:
return (header_row,
I'm surprised that we're doing this here rather than somehow using the existing
sortByColumn functionality.

[the real yoland, 2017-05-11 23:30:20]

https://codereview.chromium.org/2875803004/diff/20001/build/android/pylib/res...
File build/android/pylib/results/presentation/test_results_presentation.py
(right):

https://codereview.chromium.org/2875803004/diff/20001/build/android/pylib/res...
build/android/pylib/results/presentation/test_results_presentation.py:252:
return (header_row,
On 2017/05/11 at 23:07:57, jbudorick wrote:
> I'm surprised that we're doing this here rather than somehow using the
existing sortByColumn functionality.

Agree, I think this should be done on the front end.

[the real yoland, 2017-05-12 19:09:43]

lgtm

https://codereview.chromium.org/2875803004/diff/40001/build/android/pylib/res...
File build/android/pylib/results/presentation/javascript/main_html.js (right):

https://codereview.chromium.org/2875803004/diff/40001/build/android/pylib/res...
build/android/pylib/results/presentation/javascript/main_html.js:192:
sortByColumn(document.getElementById('number_fail_tests'));
potential future improvements: there are a lot of string values in these js/html
files. Since the result detail page are all generated through jinja on the
python side, I think it might be good to refactor and have python control over
what these string values are and send them in through jinja

[mikecase (-- gone --), 2017-05-12 19:24:59]

mikecase@chromium.org changed reviewers:
+ mikecase@chromium.org

[mikecase (-- gone --), 2017-05-12 19:24:59]

lgtm

[BigBossZhiling, 2017-05-12 21:09:17]

The CQ bit was checked by hzl@google.com

[commit-bot: I haz the power, 2017-05-12 21:10:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 23:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 23:33:49]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[BigBossZhiling, 2017-05-13 00:30:43]

The CQ bit was checked by hzl@google.com

[commit-bot: I haz the power, 2017-05-13 00:31:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 01:45:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494635443509810,
"parent_rev": "52b6764cf200aea49a5c09e221eb612394aabba7", "commit_rev":
"ad4f5792cb064c721831860a180e4f25f99cf186"}

[commit-bot: I haz the power, 2017-05-13 01:46:01]

Description was changed from

==========
Sort suites in suite table based on number of failed test cases.

We want to show suites that have failed test cases at the top of the
suite table, by default.

BUG=720382
==========

to

==========
Sort suites in suite table based on number of failed test cases.

We want to show suites that have failed test cases at the top of the
suite table, by default.

BUG=720382

Review-Url: https://codereview.chromium.org/2875803004
Cr-Commit-Position: refs/heads/master@{#471534}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad4f5792cb064c721831860a180e...
==========

[commit-bot: I haz the power, 2017-05-13 01:46:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ad4f5792cb064c721831860a180e...