Sort suites in suite table based on number of failed test cases.

build/android/pylib/results/presentation/test_results_presentation.py

 #! /usr/bin/env python
 #
 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import collections
 import json
 import tempfile
@@ skipping 230 matching lines @@
     if suite[FAIL_COUNT_INDEX]['data'] > 0:
       suite[FAIL_COUNT_INDEX]['class'] += ' failure'
     else:
       suite[FAIL_COUNT_INDEX]['class'] += ' success'
 
   if footer_row[FAIL_COUNT_INDEX]['data'] > 0:
     footer_row[FAIL_COUNT_INDEX]['class'] += ' failure'
   else:
     footer_row[FAIL_COUNT_INDEX]['class'] += ' success'
 
+  # Return the suite table on descending order of number of failed test cases.
   return (header_row,

[jbudorick, 2017/05/11 23:07:57]

I'm surprised that we're doing this here rather than somehow using the existing
sortByColumn functionality.

[the real yoland, 2017/05/11 23:30:20]

Agree, I think this should be done on the front end.

-          [[suite_row] for suite_row in suite_row_dict.values()],
+          sorted(
+              [[suite_row] for suite_row in suite_row_dict.values()],
+              key=lambda suite_row: (-1 *
+                                     suite_row[0][FAIL_COUNT_INDEX]['data'])),
           footer_row)
 
 
 def feedback_url(result_details_link):
   url_args = urllib.urlencode([
       ('labels', 'Pri-2,Type-Bug,Restrict-View-Google'),
       ('summary', 'Result Details Feedback:'),
       ('components', 'Test>Android'),
       ('comment', 'Please check out: %s' % result_details_link)])
   return 'https://bugs.chromium.org/p/chromium/issues/entry?%s' % url_args
@@ skipping 151 matching lines @@
     with open(json_file) as original_json_file:
       json_object = json.load(original_json_file)
       json_object['links'] = {'result_details': result_details_link}
       with open(args.output_json, 'w') as f:
         json.dump(json_object, f)
   else:
     print result_details_link
 
 if __name__ == '__main__':
   sys.exit(main())