Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: build/android/pylib/results/presentation/javascript/main_html.js

Issue 2875803004: Sort suites in suite table based on number of failed test cases. (Closed)
Patch Set: call sort by column in js instead Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/results/presentation/template/main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/results/presentation/javascript/main_html.js
diff --git a/build/android/pylib/results/presentation/javascript/main_html.js b/build/android/pylib/results/presentation/javascript/main_html.js
index b8f80f487f0c07e10ca30098894d33088d634a03..3d94663e33f1b8bf44eda7483c7835650d3b2ffc 100644
--- a/build/android/pylib/results/presentation/javascript/main_html.js
+++ b/build/android/pylib/results/presentation/javascript/main_html.js
@@ -88,7 +88,7 @@ function sortByColumn(head) {
// Determine whether to asc or desc and set arrows.
var headers = head.parentNode.getElementsByTagName('th');
var headIndex = Array.prototype.slice.call(headers).indexOf(head);
- var asc = 1;
+ var asc = -1;
for (var i = 0; i < headers.length; i++) {
if (headers[i].dataset.ascSorted != 0) {
if (headers[i].dataset.ascSorted == 1) {
@@ -187,3 +187,7 @@ function sortByColumn(head) {
table.appendChild(rowBlocks[i]);
}
}
+
+function sortSuiteTableByFailedTestCases() {
+ sortByColumn(document.getElementById('number_fail_tests'));
the real yoland 2017/05/12 19:09:43 potential future improvements: there are a lot of
+}
« no previous file with comments | « no previous file | build/android/pylib/results/presentation/template/main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698