Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2875793004: Coverage: misc UI polish (Closed)

Created:
3 years, 7 months ago by caseq
Modified:
3 years, 7 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Coverage: misc UI polish - make sure landing page is not truncted when sized too small - extract UI.createInlineButton() and use it in landing pages of Timeline and Coverage; - fix selected background for percentage; BUG=709352 Review-Url: https://codereview.chromium.org/2875793004 Cr-Commit-Position: refs/heads/master@{#471209} Committed: https://chromium.googlesource.com/chromium/src/+/eec30ee426ac536f96bb7d1e9e02098fd78ba594

Patch Set 1 #

Patch Set 2 : removed unused stuff in coverageView.css #

Patch Set 3 : fix sorting #

Total comments: 1

Patch Set 4 : review comments, dropped some stray lines #

Messages

Total messages: 9 (5 generated)
caseq
3 years, 7 months ago (2017-05-11 23:08:04 UTC) #2
alph
lgtm https://codereview.chromium.org/2875793004/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/inlineButton.css File third_party/WebKit/Source/devtools/front_end/ui/inlineButton.css (right): https://codereview.chromium.org/2875793004/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/inlineButton.css#newcode1 third_party/WebKit/Source/devtools/front_end/ui/inlineButton.css:1: :host { copyright
3 years, 7 months ago (2017-05-12 00:46:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875793004/60001
3 years, 7 months ago (2017-05-12 01:26:15 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 03:41:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/eec30ee426ac536f96bb7d1e9e02...

Powered by Google App Engine
This is Rietveld 408576698