third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js - Issue 2875793004: Coverage: misc UI polish

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

Issue 2875793004: Coverage: misc UI polish (Closed)

Patch Set: review comments, dropped some stray lines Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/BUILD.gn ('k') | third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

index 48d48725d110f48aadf7a0161f0be53c5732550e..16d890e28d65b7bf0efab84ddcd8da86915dba36 100644

--- a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

+++ b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

@@ -139,7 +139,7 @@ Coverage.CoverageListView = class extends UI.VBox {

var nodeA = /** @type {!Coverage.CoverageListView.GridNode} */ (a);

var nodeB = /** @type {!Coverage.CoverageListView.GridNode} */ (b);

- return nodeA._displayURL.localeCompare(nodeB._displayURL);

+ return nodeA._url.localeCompare(nodeB._url);

}

/**

@@ -193,7 +193,6 @@ Coverage.CoverageListView.GridNode = class extends DataGrid.SortableDataGridNode

/** @type {number|undefined} */

this._lastUsedSize;

this._url = coverageInfo.url();

- this._displayURL = new Common.ParsedURL(this._url).displayName;

this._maxSize = maxSize;

}