Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js

Issue 2875793004: Coverage: misc UI polish (Closed)
Patch Set: review comments, dropped some stray lines Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
index 084d40af68e158aee03dd6b5469221f75cad8201..52156c4af57ea2c2399728398ad635f19f4a4d4d 100644
--- a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
+++ b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
@@ -33,12 +33,13 @@ Coverage.CoverageView = class extends UI.VBox {
topToolbar.appendToolbarItem(this._clearButton);
this._coverageResultsElement = this.contentElement.createChild('div', 'coverage-results');
- this._progressElement = this._coverageResultsElement.createChild('div', 'progress-view');
+ this._landingPage = this._buildLandingPage();
+
this._listView = new Coverage.CoverageListView();
this._statusToolbarElement = this.contentElement.createChild('div', 'coverage-toolbar-summary');
this._statusMessageElement = this._statusToolbarElement.createChild('div', 'coverage-message');
- this._showHelpScreen();
+ this._landingPage.show(this._coverageResultsElement);
}
_reset() {
@@ -48,24 +49,25 @@ Coverage.CoverageView = class extends UI.VBox {
}
this._listView.reset();
this._listView.detach();
- this._coverageResultsElement.removeChildren();
- this._showHelpScreen();
-
+ this._landingPage.show(this._coverageResultsElement);
this._statusMessageElement.textContent = '';
}
- _showHelpScreen() {
- this._coverageResultsElement.appendChild(this._progressElement);
- this._progressElement.removeChildren();
-
- var recordButton = UI.Toolbar.createActionButton(this._toggleRecordAction).element;
- var reloadButton = UI.Toolbar.createActionButtonForId('coverage.start-with-reload').element;
-
- this._progressElement.createChild('p', 'landing-page')
- .appendChild(UI.formatLocalized(
- 'Click the record button %s to start capturing coverage.\n' +
- 'Click the reload button %s to reload and start capturing coverage.',
- [recordButton, reloadButton]));
+ /**
+ * @return {!UI.VBox}
+ */
+ _buildLandingPage() {
+ var recordButton = UI.createInlineButton(UI.Toolbar.createActionButton(this._toggleRecordAction));
+ var reloadButton = UI.createInlineButton(UI.Toolbar.createActionButtonForId('coverage.start-with-reload'));
+ var widget = new UI.VBox();
+ var message = UI.formatLocalized(
+ 'Click the record button %s to start capturing coverage.\n' +
+ 'Click the reload button %s to reload and start capturing coverage.',
+ [recordButton, reloadButton]);
+ message.classList.add('message');
+ widget.contentElement.appendChild(message);
+ widget.element.classList.add('landing-page');
+ return widget;
}
_toggleRecording() {
@@ -102,7 +104,8 @@ Coverage.CoverageView = class extends UI.VBox {
this._toggleRecordAction.setToggled(true);
this._clearButton.setEnabled(false);
this._startWithReloadButton.setEnabled(false);
- this._coverageResultsElement.removeChildren();
+ if (this._landingPage.isShowing())
+ this._landingPage.detach();
this._listView.show(this._coverageResultsElement);
this._poll();
}

Powered by Google App Engine
This is Rietveld 408576698